[PR #6306] [MERGED] fix: reordering or creating a row while sorts are active #7300

New issue

Closed

opened 2026-03-23 23:19:00 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6306
Author: @richardshiue
Created: 9/14/2024
Status: ✅ Merged
Merged: 9/15/2024
Merged by: @richardshiue

Base: main ← Head: fix/reorder-or-create-row-while-sorting

📝 Commits (2)

67f13a9 fix: reordering or creating a row while sorts are active
9bc47ee test: fix integration test

📊 Changes

8 files changed (+144 additions, -83 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/board/board_row_test.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/field_info.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart (+32 -9)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/action.dart (+37 -17)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/row.dart (+60 -45)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/shared_widget.dart (+1 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart (+2 -2)
📝 frontend/resources/translations/en.json (+10 -5)

📄 Description

Inform the user why inserting a new row before or after a row, or reordering rows is not allowed when there are sorts configured for the current grid view; and give an option to remove sorting in order to continue.

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6306 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/14/2024 **Status:** ✅ Merged **Merged:** 9/15/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/reorder-or-create-row-while-sorting` --- ### 📝 Commits (2) - [`67f13a9`](https://github.com/AppFlowy-IO/AppFlowy/commit/67f13a98b5ca8f1da392848cb064ef362e281948) fix: reordering or creating a row while sorts are active - [`9bc47ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/9bc47ee651e68dcfff9827b4dac83b9eca108e5c) test: fix integration test ### 📊 Changes **8 files changed** (+144 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/board/board_row_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/field_info.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart` (+32 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/action.dart` (+37 -17) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/row/row.dart` (+60 -45) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/shared_widget.dart` (+1 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart` (+2 -2) 📝 `frontend/resources/translations/en.json` (+10 -5) </details> ### 📄 Description Inform the user why inserting a new row before or after a row, or reordering rows is not allowed when there are sorts configured for the current grid view; and give an option to remove sorting in order to continue. ![Screenshot 2024-09-14 at 9 56 27 AM](https://github.com/user-attachments/assets/bd033ca3-b5dd-47f3-9aad-9ce63c503ddb) ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>