[PR #6317] [MERGED] fix: grid filters #7306

New issue

Closed

opened 2026-03-23 23:19:01 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6317
Author: @richardshiue
Created: 9/16/2024
Status: ✅ Merged
Merged: 9/16/2024
Merged by: @appflowy

Base: main ← Head: fix/filters

📝 Commits (2)

e38c8a7 fix: grid filters
5811359 chore: merge remote-tracking branch 'upstream/main' into this one

📊 Changes

6 files changed (+69 additions, -108 deletions)

View changed files

📝 frontend/rust-lib/flowy-database2/src/services/database/database_observe.rs (+14 -23)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/notifier.rs (+3 -15)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+30 -25)
📝 frontend/rust-lib/flowy-database2/src/services/sort/controller.rs (+21 -36)
📝 frontend/rust-lib/flowy-database2/src/services/sort/entities.rs (+1 -8)
📝 frontend/rust-lib/flowy-database2/tests/database/sort_test/script.rs (+0 -1)

📄 Description

new rows are not being inserted at the correct position when filters are active

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6317 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/16/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix/filters` --- ### 📝 Commits (2) - [`e38c8a7`](https://github.com/AppFlowy-IO/AppFlowy/commit/e38c8a732098eae83dbf6038b976f1c3a3a10274) fix: grid filters - [`5811359`](https://github.com/AppFlowy-IO/AppFlowy/commit/5811359b471d69506a797e8a861d4d60cb919664) chore: merge remote-tracking branch 'upstream/main' into this one ### 📊 Changes **6 files changed** (+69 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_observe.rs` (+14 -23) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/notifier.rs` (+3 -15) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+30 -25) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/controller.rs` (+21 -36) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/entities.rs` (+1 -8) 📝 `frontend/rust-lib/flowy-database2/tests/database/sort_test/script.rs` (+0 -1) </details> ### 📄 Description new rows are not being inserted at the correct position when filters are active ### Feature Preview  ---  #### PR Checklist - [ ] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>