[PR #6315] [MERGED] fix: untitled override the true value in row details page #7307

New issue

Closed

opened 2026-03-23 23:19:01 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6315
Author: @appflowy
Created: 9/15/2024
Status: ✅ Merged
Merged: 9/16/2024
Merged by: @appflowy

Base: main ← Head: fix_row_detail_title

📝 Commits (4)

90e284b fix: untitled override the true value in row details page
1c37d73 chore: use on complete edit callback
88c8465 chore: fix test
32a9053 chore: fix test

📊 Changes

17 files changed (+74 additions, -67 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/row_page_button.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/text_cell_bloc.dart (+8 -6)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/text.dart (+6 -3)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/plugins/database_document/presentation/database_document_title.dart (+1 -1)
📝 frontend/appflowy_tauri/src-tauri/Cargo.lock (+7 -7)
📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+7 -7)
📝 frontend/appflowy_web_app/src-tauri/Cargo.lock (+7 -7)
📝 frontend/appflowy_web_app/src-tauri/Cargo.toml (+7 -7)
📝 frontend/rust-lib/Cargo.lock (+7 -7)
📝 frontend/rust-lib/Cargo.toml (+7 -7)
📝 frontend/rust-lib/flowy-core/Cargo.toml (+4 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+2 -0)

📄 Description

replace onEditing callback with onComplete callback
fix the title of row detail page is overwritten with untitled text

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6315 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 9/15/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix_row_detail_title` --- ### 📝 Commits (4) - [`90e284b`](https://github.com/AppFlowy-IO/AppFlowy/commit/90e284bd385dd7e66f365a27e13e27a91d97e108) fix: untitled override the true value in row details page - [`1c37d73`](https://github.com/AppFlowy-IO/AppFlowy/commit/1c37d73bd20aeebba9aa49fc7f1d9e9041a383e4) chore: use on complete edit callback - [`88c8465`](https://github.com/AppFlowy-IO/AppFlowy/commit/88c846519b8a3cae72ff7510659edb397f01e81e) chore: fix test - [`32a9053`](https://github.com/AppFlowy-IO/AppFlowy/commit/32a9053796845e0c579f4e4e232ae50d98fb643c) chore: fix test ### 📊 Changes **17 files changed** (+74 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/mobile_card_detail_screen.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/card/card_detail/widgets/row_page_button.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/text_cell_bloc.dart` (+8 -6) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_event_editor.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/text.dart` (+6 -3) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_banner.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database_document/presentation/database_document_title.dart` (+1 -1) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.lock` (+7 -7) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+7 -7) 📝 `frontend/appflowy_web_app/src-tauri/Cargo.lock` (+7 -7) 📝 `frontend/appflowy_web_app/src-tauri/Cargo.toml` (+7 -7) 📝 `frontend/rust-lib/Cargo.lock` (+7 -7) 📝 `frontend/rust-lib/Cargo.toml` (+7 -7) 📝 `frontend/rust-lib/flowy-core/Cargo.toml` (+4 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+2 -0) </details> ### 📄 Description 1. replace onEditing callback with onComplete callback 2. fix the title of row detail page is overwritten with untitled text --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>