[PR #6356] [MERGED] refactor: filter blocs #7332

New issue

Closed

opened 2026-03-23 23:19:08 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6356
Author: @richardshiue
Created: 9/19/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @richardshiue

Base: main ← Head: refactor/filter-bloc

📝 Commits (9)

6ab7d71 refactor: database filter bloc
d0c0eaa refactor: filter choice chips
5c1a0e5 fix: update field info in filters
af269ba refactor: simplify select option filter panel
19c3879 test: fix tests
c4f2f5b refactor: filter choice chips
4dacf37 test: add bloc tests
8be2320 chore: merge remote-tracking branch 'upstream/main' into this one
0d524ac refactor: date time filter bloc and choice chip

📊 Changes

64 files changed (+1977 additions, -2707 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+7 -6)
📝 frontend/appflowy_flutter/ios/Podfile.lock (+0 -6)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_sort_bottom_sheet.dart (+10 -7)
📝 frontend/appflowy_flutter/lib/plugins/database/application/defines.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/field_controller.dart (+13 -38)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/field_info.dart (+0 -67)
➕ frontend/appflowy_flutter/lib/plugins/database/application/field/filter_entities.dart (+458 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/board/presentation/toolbar/board_setting_bar.dart (+26 -28)
📝 frontend/appflowy_flutter/lib/plugins/database/domain/filter_service.dart (+1 -4)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/checkbox_filter_editor_bloc.dart (+0 -105)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/checklist_filter_bloc.dart (+0 -107)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/date_filter_editor_bloc.dart (+0 -132)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_editor_bloc.dart (+89 -81)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_menu_bloc.dart (+0 -129)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/number_filter_editor_bloc.dart (+0 -111)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/select_option_filter_bloc.dart (+0 -146)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/select_option_filter_list_bloc.dart (+0 -158)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/select_option_loader.dart (+15 -16)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/text_filter_editor_bloc.dart (+0 -130)
➖ frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/time_filter_editor_bloc.dart (+0 -111)

...and 44 more files

📄 Description

Also fixes a bug where changing a field's properties such as its name and the available options for select field types doesn't change those properties on the filter chips.

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6356 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/19/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `refactor/filter-bloc` --- ### 📝 Commits (9) - [`6ab7d71`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ab7d712fda29efe24e536eae0e6fe4650e46e32) refactor: database filter bloc - [`d0c0eaa`](https://github.com/AppFlowy-IO/AppFlowy/commit/d0c0eaa51e83ebf88235acb9dbf0f59203b9ac87) refactor: filter choice chips - [`5c1a0e5`](https://github.com/AppFlowy-IO/AppFlowy/commit/5c1a0e56ae8b21798c5d4dc47af23f6eda82d2df) fix: update field info in filters - [`af269ba`](https://github.com/AppFlowy-IO/AppFlowy/commit/af269bacca85a6496f8caf421c043103b2362431) refactor: simplify select option filter panel - [`19c3879`](https://github.com/AppFlowy-IO/AppFlowy/commit/19c38791a567fa668be9086f26ac3b91d8f4cb29) test: fix tests - [`c4f2f5b`](https://github.com/AppFlowy-IO/AppFlowy/commit/c4f2f5bce82b7bd8ee6e3ef9473d1fea3bd39087) refactor: filter choice chips - [`4dacf37`](https://github.com/AppFlowy-IO/AppFlowy/commit/4dacf37f38817915e476bf003eff13e56911dd8b) test: add bloc tests - [`8be2320`](https://github.com/AppFlowy-IO/AppFlowy/commit/8be232099349f88d385cc8d51d95b31f6a2f2400) chore: merge remote-tracking branch 'upstream/main' into this one - [`0d524ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/0d524ac35eaa2f56cb12ab255504d7bfcd0599ae) refactor: date time filter bloc and choice chip ### 📊 Changes **64 files changed** (+1977 additions, -2707 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+7 -6) 📝 `frontend/appflowy_flutter/ios/Podfile.lock` (+0 -6) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_sort_bottom_sheet.dart` (+10 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/defines.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/field_controller.dart` (+13 -38) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/field_info.dart` (+0 -67) ➕ `frontend/appflowy_flutter/lib/plugins/database/application/field/filter_entities.dart` (+458 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/presentation/toolbar/board_setting_bar.dart` (+26 -28) 📝 `frontend/appflowy_flutter/lib/plugins/database/domain/filter_service.dart` (+1 -4) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/checkbox_filter_editor_bloc.dart` (+0 -105) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/checklist_filter_bloc.dart` (+0 -107) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/date_filter_editor_bloc.dart` (+0 -132) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_editor_bloc.dart` (+89 -81) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_menu_bloc.dart` (+0 -129) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/number_filter_editor_bloc.dart` (+0 -111) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/select_option_filter_bloc.dart` (+0 -146) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/select_option_filter_list_bloc.dart` (+0 -158) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/select_option_loader.dart` (+15 -16) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/text_filter_editor_bloc.dart` (+0 -130) ➖ `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/time_filter_editor_bloc.dart` (+0 -111) _...and 44 more files_ </details> ### 📄 Description Also fixes a bug where changing a field's properties such as its name and the available options for select field types doesn't change those properties on the filter chips. ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>