AppFlowy-IO/AppFlowy

Fork 0

mirror of https://github.com/AppFlowy-IO/AppFlowy.git synced 2026-03-24 12:56:59 +00:00

[GH-ISSUE #1876] [Bug] Shortcut event doesn't work in some keyboard layout type #734

New issue

Closed

opened 2026-03-23 20:40:21 +00:00 by mirror · 11 comments

mirror commented

2026-03-23 20:40:21 +00:00

Owner

Originally created by @LucasXu0 on GitHub (Feb 21, 2023).
Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1876

Bug Description

For example, the slash command doesn't work in Sweden's keyboard layout type.

How to Reproduce

Switch the keyboard layout type to Sweden.
Press the slash /.
The slash menu doesn't show.

Expected Behavior

The slash menu shows as expected.

Operating System

macOS

AppFlowy Version(s)

0.1.0

Screenshots

Additional Context

For now, the editor uses LogicalKeyboardKey.xxx to determine which event has been triggered.

Originally created by @LucasXu0 on GitHub (Feb 21, 2023). Original GitHub issue: https://github.com/AppFlowy-IO/AppFlowy/issues/1876 ### Bug Description For example, the slash command doesn't work in Sweden's keyboard layout type. ### How to Reproduce 1. Switch the keyboard layout type to Sweden. 2. Press the slash `/`. 3. The slash menu doesn't show. ### Expected Behavior The slash menu shows as expected. ### Operating System macOS ### AppFlowy Version(s) 0.1.0 ### Screenshots <img width="899" alt="Screenshot 2023-02-21 at 11 52 10" src="https://user-images.githubusercontent.com/11863087/220243276-48b24584-3244-4e66-a59a-0d05014357b7.png"> ### Additional Context For now, the editor uses LogicalKeyboardKey.xxx to determine which event has been triggered.

mirror

2026-03-23 20:40:21 +00:00

closed this issue
added the
help wanted

editor
labels

mirror commented

2026-03-23 20:40:22 +00:00

Author

Owner

@MayurSMahajan commented on GitHub (Feb 21, 2023):

As a permanent solution, for this issue and similar issues like these, we are going to implement Custom Shortcuts Feature. Wherein the users will be able to customize these kinds of functionalities with whatever key combinations of their choice.

@MayurSMahajan commented on GitHub (Feb 21, 2023): As a permanent solution, for this issue and similar issues like these, we are going to implement **Custom Shortcuts Feature**. Wherein the users will be able to customize these kinds of functionalities with whatever key combinations of their choice.

mirror commented

2026-03-23 20:40:22 +00:00

Author

Owner

@LucasXu0 commented on GitHub (Feb 21, 2023):

As a permanent solution, for this issue and similar issues like these, we are going to implement Custom Shortcuts Feature. Wherein the users will be able to customize these kinds of functionalities with whatever key combinations of their choice.

Yes. However, for some built-in shortcuts, like slash, enter, and backspace those required shortcuts, we don't want users to have to customize shortcuts to use them, although they can customize them.

@LucasXu0 commented on GitHub (Feb 21, 2023): > As a permanent solution, for this issue and similar issues like these, we are going to implement **Custom Shortcuts Feature**. Wherein the users will be able to customize these kinds of functionalities with whatever key combinations of their choice. Yes. However, for some built-in shortcuts, like slash, enter, and backspace those required shortcuts, we don't want users to have to customize shortcuts to use them, although they can customize them.

mirror commented

2026-03-23 20:40:22 +00:00

Author

Owner

@devzu commented on GitHub (Feb 24, 2023):

From Sweden, with a swedish keyboard layout, and just came here because this is the first thing I noticed when trying out AppFlowy for the first time.
There's no other way to open this menu either - so I cannot do anything but just write text and change the styling of it.
As a user, I agree with LucasXu0, I don't think users should have to costumize shortcuts to even be able to use the app.

@devzu commented on GitHub (Feb 24, 2023): From Sweden, with a swedish keyboard layout, and just came here because this is the first thing I noticed when trying out AppFlowy for the first time. There's no other way to open this menu either - so I cannot do anything but just write text and change the styling of it. As a user, I agree with LucasXu0, I don't think users should have to costumize shortcuts to even be able to _use_ the app.

mirror commented

2026-03-23 20:40:23 +00:00

Author

Owner

@rileyhawk1417 commented on GitHub (Mar 6, 2023):

@devzu would a auto-detect feature layout work?

@rileyhawk1417 commented on GitHub (Mar 6, 2023): @devzu would a `auto-detect` feature layout work?

mirror commented

2026-03-23 20:40:23 +00:00

Author

Owner

@annieappflowy commented on GitHub (Mar 9, 2023):

Status on fixing this issue? @LucasXu0

@annieappflowy commented on GitHub (Mar 9, 2023): Status on fixing this issue? @LucasXu0

mirror commented

2026-03-23 20:40:23 +00:00

Author

Owner

@Xazin commented on GitHub (Mar 21, 2023):

This is a POC for TextEventHandlers, that would abstract Text Commands from Keyboard Commands: github.com/Xazin/appflowy-editor@ffb57d1394

This would solve it for any keyboard layout.

(Based on Discord convo in AppFlowy Discord)

@Xazin commented on GitHub (Mar 21, 2023): This is a POC for TextEventHandlers, that would abstract Text Commands from Keyboard Commands: https://github.com/Xazin/appflowy-editor/commit/ffb57d1394499da326ed3d59f0760d771c28af3d This would solve it for any keyboard layout. _(Based on Discord convo in AppFlowy Discord)_

mirror commented

2026-03-23 20:40:23 +00:00

Author

Owner

@miko007 commented on GitHub (Apr 1, 2023):

i do not really know how things work here, but if this has been merged last week, is there a specific reason, this fix is not present in the latest release?

@miko007 commented on GitHub (Apr 1, 2023): i do not really know how things work here, but if this has been merged last week, is there a specific reason, this fix is not present in the latest release?

mirror commented

2026-03-23 20:40:24 +00:00

Author

Owner

@annieappflowy commented on GitHub (Apr 6, 2023):

@miko007 , I suppose it's fixed. What keyboard do you use? And which version do you run on?

@annieappflowy commented on GitHub (Apr 6, 2023): @miko007 , I suppose it's fixed. What keyboard do you use? And which version do you run on?

mirror commented

2026-03-23 20:40:24 +00:00

Author

Owner

@LucasXu0 commented on GitHub (Apr 6, 2023):

Hey, @miko007. This issue has been fixed, but it hasn't been included in the new version yet. Now we trigger the slash menu by typing the character '/'. This means it won't be affected by the keyboard type again.

@LucasXu0 commented on GitHub (Apr 6, 2023): Hey, @miko007. This issue has been fixed, but it hasn't been included in the new version yet. Now we trigger the slash menu by typing the character '/'. This means it won't be affected by the keyboard type again.

mirror commented

2026-03-23 20:40:24 +00:00

Author

Owner

@miko007 commented on GitHub (Apr 24, 2023):

with AppFlowy v0.1.3 i can now confirm, that this is no longer an issue. the / command now works on all my devices.

@miko007 commented on GitHub (Apr 24, 2023): with AppFlowy v0.1.3 i can now confirm, that this is no longer an issue. the `/` command now works on all my devices.

mirror commented

2026-03-23 20:40:24 +00:00

Author

Owner

@Xazin commented on GitHub (May 13, 2023):

@annieappflowy This can be closed again 👍

@Xazin commented on GitHub (May 13, 2023): @annieappflowy This can be closed again :+1:

mirror referenced this issue

2026-03-23 21:37:13 +00:00

[PR #734] [MERGED] Supplementary translations in Simplified Chinese #4303