[PR #6376] [MERGED] fix: semi-transparent colors being forced to full opacity in FlowySvg #7346

New issue

Closed

opened 2026-03-23 23:19:12 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6376
Author: @richardshiue
Created: 9/21/2024
Status: ✅ Merged
Merged: 9/23/2024
Merged by: @richardshiue

Base: main ← Head: fix/icon-colors

📝 Commits (3)

f3296c6 fix: semi-transparent colors being forced to full opacity
81ba895 chore: code style
5196ded chore: update comment

📊 Changes

1 file changed (+9 additions, -6 deletions)

View changed files

📝 frontend/appflowy_flutter/packages/flowy_svg/lib/src/flowy_svg.dart (+9 -6)

📄 Description

As an example, hintColor on mobile is not a fully-opaque gray color, but black with its opacity toned down. When passed to FlowySvg, this color's opacity is cranked back up to 1.0. In the sort panel, both the "no active sorts" text and the sort icon specify this hint color but look completely different. In the second example, notice the plus sign next to the words "new row".

Before:

After:

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6376 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/21/2024 **Status:** ✅ Merged **Merged:** 9/23/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/icon-colors` --- ### 📝 Commits (3) - [`f3296c6`](https://github.com/AppFlowy-IO/AppFlowy/commit/f3296c66272bde913256f0bc3bd19edf8e54e6f9) fix: semi-transparent colors being forced to full opacity - [`81ba895`](https://github.com/AppFlowy-IO/AppFlowy/commit/81ba8954b602f83933f5895c41a120f4723c894b) chore: code style - [`5196ded`](https://github.com/AppFlowy-IO/AppFlowy/commit/5196dede3dd4d1021d479abb6b464feed323cf62) chore: update comment ### 📊 Changes **1 file changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/packages/flowy_svg/lib/src/flowy_svg.dart` (+9 -6) </details> ### 📄 Description As an example, hintColor on mobile is not a fully-opaque gray color, but black with its opacity toned down. When passed to FlowySvg, this color's opacity is cranked back up to 1.0. In the sort panel, both the "no active sorts" text and the sort icon specify this hint color but look completely different. In the second example, notice the plus sign next to the words "new row". Before: ![Screenshot 2024-09-21 at 10 07 41 PM](https://github.com/user-attachments/assets/d35f98b8-2707-4a5c-abc6-1a3684b108d2) ![Screenshot 2024-09-21 at 10 08 20 PM](https://github.com/user-attachments/assets/fee9be92-93fe-4678-855a-108f0ac812cd) After: ![Screenshot 2024-09-21 at 10 07 01 PM](https://github.com/user-attachments/assets/dc98457f-d04c-49b6-918e-650805522d46) ![Screenshot 2024-09-21 at 10 08 53 PM](https://github.com/user-attachments/assets/d5da10e3-0f3f-454d-b894-81cf606165cc) ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>