[PR #6380] [MERGED] feat: add numpadSubtract as zoom out keycode #7349

New issue

Closed

opened 2026-03-23 23:19:12 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6380
Author: @LucasXu0
Created: 9/23/2024
Status: ✅ Merged
Merged: 9/23/2024
Merged by: @LucasXu0

Base: main ← Head: zoom_out_hotkey

📝 Commits (5)

c63e767 feat: add numpadSubtract as zoom out keycode
8a27065 test: add zoom in/out and reset zoom refacotr test
eb53e33 fix: zoom in test assertion
c70e1fc fix: zoom in/out test
7743884 test: exclude LogicalKeyboardKey.add & LogicalKeyboardKey.numpadSubtract in linux test

📊 Changes

4 files changed (+181 additions, -22 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/desktop/uncategorized/zoom_in_out_test.dart (+122 -0)
📝 frontend/appflowy_flutter/integration_test/desktop_runner_3.dart (+6 -3)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+9 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart (+44 -17)

📄 Description

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/6311

add numpadAdd to zoom in keycodes.
add numpadSubtract to zoom out keycodes.
add numpad0 to reset zoom keycodes.
add tests

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6380 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 9/23/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `zoom_out_hotkey` --- ### 📝 Commits (5) - [`c63e767`](https://github.com/AppFlowy-IO/AppFlowy/commit/c63e767f63d7dc70eead5313ced519f29c548147) feat: add numpadSubtract as zoom out keycode - [`8a27065`](https://github.com/AppFlowy-IO/AppFlowy/commit/8a2706576b0d89575955af68abd224ceb159ad03) test: add zoom in/out and reset zoom refacotr test - [`eb53e33`](https://github.com/AppFlowy-IO/AppFlowy/commit/eb53e33e02159fcc4022eb6af24a69c33d4a03d1) fix: zoom in test assertion - [`c70e1fc`](https://github.com/AppFlowy-IO/AppFlowy/commit/c70e1fc69f8f3530f127d10118480b715aad8a1a) fix: zoom in/out test - [`7743884`](https://github.com/AppFlowy-IO/AppFlowy/commit/77438841e53292b38af0bd21fdc3a273e729e30d) test: exclude LogicalKeyboardKey.add & LogicalKeyboardKey.numpadSubtract in linux test ### 📊 Changes **4 files changed** (+181 additions, -22 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/desktop/uncategorized/zoom_in_out_test.dart` (+122 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop_runner_3.dart` (+6 -3) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+9 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/hotkeys.dart` (+44 -17) </details> ### 📄 Description   ### Feature Preview closes https://github.com/AppFlowy-IO/AppFlowy/issues/6311 - [x] add `numpadAdd` to zoom in keycodes. - [x] add `numpadSubtract` to zoom out keycodes. - [x] add `numpad0` to reset zoom keycodes. - [x] add tests  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>