[PR #6386] [MERGED] feat: support appflowy cloud in sign-in settings page #7353

Closed
opened 2026-03-23 23:19:14 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6386
Author: @LucasXu0
Created: 9/23/2024
Status: Merged
Merged: 9/23/2024
Merged by: @LucasXu0

Base: mainHead: optimize_self_hosted_section_in_settings


📝 Commits (3)

  • 9d4be12 feat: support appflowy cloud in sign-in settings page
  • 6ee8edc test: add cloud server test
  • 3e26458 test: wait until the tooltip disappear

📊 Changes

6 files changed (+281 additions, -65 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/settings/settings_runner.dart (+2 -0)
frontend/appflowy_flutter/integration_test/desktop/settings/sign_in_page_settings_test.dart (+103 -0)
📝 frontend/appflowy_flutter/lib/flutter/af_dropdown_menu.dart (+16 -10)
📝 frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/desktop_sign_in_screen.dart (+5 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart (+154 -50)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/settings_dropdown.dart (+1 -2)

📄 Description

Feature Preview

  • support appflowy-cloud in sign-in settings page
  • add test

self-hosted
Screenshot 2024-09-23 at 15 27 02

appflowy cloud
Screenshot 2024-09-23 at 15 27 13


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6386 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 9/23/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `optimize_self_hosted_section_in_settings` --- ### 📝 Commits (3) - [`9d4be12`](https://github.com/AppFlowy-IO/AppFlowy/commit/9d4be122c716023e9db9cdb6761b56b2eb1775af) feat: support appflowy cloud in sign-in settings page - [`6ee8edc`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ee8edca4c8437da84400bdf67db2b64ae4c3a2f) test: add cloud server test - [`3e26458`](https://github.com/AppFlowy-IO/AppFlowy/commit/3e26458a7a4bc2a619ae6e4f73eebd7f59bdb7f6) test: wait until the tooltip disappear ### 📊 Changes **6 files changed** (+281 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/settings/settings_runner.dart` (+2 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/settings/sign_in_page_settings_test.dart` (+103 -0) 📝 `frontend/appflowy_flutter/lib/flutter/af_dropdown_menu.dart` (+16 -10) 📝 `frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/desktop_sign_in_screen.dart` (+5 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/settings_dialog.dart` (+154 -50) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/settings_dropdown.dart` (+1 -2) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] support appflowy-cloud in sign-in settings page - [x] add test self-hosted <img width="1072" alt="Screenshot 2024-09-23 at 15 27 02" src="https://github.com/user-attachments/assets/7b23edf0-6178-4de7-b055-01e920c94ca1"> appflowy cloud <img width="1072" alt="Screenshot 2024-09-23 at 15 27 13" src="https://github.com/user-attachments/assets/b00b3bea-4a29-4e48-a115-e12fbe41e2f9"> <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:14 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7353
No description provided.