[PR #6399] [MERGED] feat: allow filtering by date end #7362

Closed
opened 2026-03-23 23:19:16 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6399
Author: @richardshiue
Created: 9/25/2024
Status: Merged
Merged: 9/25/2024
Merged by: @richardshiue

Base: mainHead: feat/date-time-filter-improvements


📝 Commits (1)

  • e547ac4 feat: allow filtering by date end

📊 Changes

16 files changed (+586 additions, -204 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_filter_test.dart (+3 -2)
📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/filter_entities.dart (+108 -17)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_editor_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/date.dart (+134 -31)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker.dart (+28 -20)
📝 frontend/resources/translations/en.json (+4 -1)
📝 frontend/rust-lib/flowy-database2/src/entities/filter_entities/date_filter.rs (+49 -16)
📝 frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs (+6 -4)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_filter.rs (+233 -97)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/date_controller.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/group/controller_impls/select_option_controller/util.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/tests/database/filter_test/advanced_filter_test.rs (+2 -2)
📝 frontend/rust-lib/flowy-database2/tests/database/filter_test/date_filter_test.rs (+5 -5)
📝 frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs (+7 -3)
📝 frontend/rust-lib/flowy-database2/tests/database/pre_fill_cell_test/pre_fill_row_according_to_filter_test.rs (+2 -2)

📄 Description

Screenshot 2024-09-25 at 3 00 56 PM

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6399 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/date-time-filter-improvements` --- ### 📝 Commits (1) - [`e547ac4`](https://github.com/AppFlowy-IO/AppFlowy/commit/e547ac4935f3dcd080d6bc1c8131e0eda4905250) feat: allow filtering by date end ### 📊 Changes **16 files changed** (+586 additions, -204 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_filter_test.dart` (+3 -2) 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/filter_entities.dart` (+108 -17) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_editor_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/date.dart` (+134 -31) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker.dart` (+28 -20) 📝 `frontend/resources/translations/en.json` (+4 -1) 📝 `frontend/rust-lib/flowy-database2/src/entities/filter_entities/date_filter.rs` (+49 -16) 📝 `frontend/rust-lib/flowy-database2/src/services/cell/cell_operation.rs` (+6 -4) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_filter.rs` (+233 -97) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/date_controller.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/group/controller_impls/select_option_controller/util.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/tests/database/filter_test/advanced_filter_test.rs` (+2 -2) 📝 `frontend/rust-lib/flowy-database2/tests/database/filter_test/date_filter_test.rs` (+5 -5) 📝 `frontend/rust-lib/flowy-database2/tests/database/group_test/script.rs` (+7 -3) 📝 `frontend/rust-lib/flowy-database2/tests/database/pre_fill_cell_test/pre_fill_row_according_to_filter_test.rs` (+2 -2) </details> ### 📄 Description ![Screenshot 2024-09-25 at 3 00 56 PM](https://github.com/user-attachments/assets/4d706936-dd70-4356-8046-2a4f1c7fdb73) ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:16 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7362
No description provided.