[PR #6406] [MERGED] fix: grid cell date time test #7364

New issue

Closed

opened 2026-03-23 23:19:17 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6406
Author: @LucasXu0
Created: 9/26/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @LucasXu0

Base: main ← Head: fix_grid_cell_date_time

📝 Commits (2)

36ce305 fix: grid cell date time test
7cfcbd1 chore: delete test

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_cell_test.dart (+4 -4)

📄 Description

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/6405

The hours and minutes are from the previously set up time, not from the current time. So there may be a potential issue when using datetime.now to check the result.

Added a 50-time test to reproduce this issue. Delete the test if all of them are successful.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6406 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_grid_cell_date_time` --- ### 📝 Commits (2) - [`36ce305`](https://github.com/AppFlowy-IO/AppFlowy/commit/36ce30523b12ca90b172ce3140e641f1c6c6ef94) fix: grid cell date time test - [`7cfcbd1`](https://github.com/AppFlowy-IO/AppFlowy/commit/7cfcbd1dd4e9902f9cf123dedec880a07edeeba5) chore: delete test ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_cell_test.dart` (+4 -4) </details> ### 📄 Description   ### Feature Preview closes https://github.com/AppFlowy-IO/AppFlowy/issues/6405 The hours and minutes are from the previously set up time, not from the current time. So there may be a potential issue when using `datetime.now` to check the result. Added a 50-time test to reproduce this issue. Delete the test if all of them are successful.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>