[PR #6409] [MERGED] fix: hide editing rows from groups when filters are applied #7366

Closed
opened 2026-03-23 23:19:17 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6409
Author: @richardshiue
Created: 9/26/2024
Status: Merged
Merged: 10/3/2024
Merged by: @richardshiue

Base: mainHead: fix/board-filters


📝 Commits (2)

  • 736fe3f fix: editing a row while in active filters
  • 881fa31 fix: dont allow filtering by group field

📊 Changes

2 files changed (+39 additions, -26 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_editor_bloc.dart (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+38 -25)

📄 Description

https://github.com/user-attachments/assets/bf0b0e74-5489-443b-b34b-4e7b3999365f

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6409 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/board-filters` --- ### 📝 Commits (2) - [`736fe3f`](https://github.com/AppFlowy-IO/AppFlowy/commit/736fe3fc6df97b8b9fd94a26e51c3d86dcfadd7c) fix: editing a row while in active filters - [`881fa31`](https://github.com/AppFlowy-IO/AppFlowy/commit/881fa31b2be31374487ed6dbda019c36093ea38b) fix: dont allow filtering by group field ### 📊 Changes **2 files changed** (+39 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_editor_bloc.dart` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+38 -25) </details> ### 📄 Description https://github.com/user-attachments/assets/bf0b0e74-5489-443b-b34b-4e7b3999365f ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:17 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7366
No description provided.