[PR #6447] [MERGED] fix: date issue when enbling time feild #7386

New issue

Closed

opened 2026-03-23 23:19:23 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6447
Author: @Ahad-patel
Created: 10/1/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @LucasXu0

Base: main ← Head: fix-current-time

📝 Commits (8)

66e6c21 fix: date issue when enbling time field
70e64dd chore: add integration test for date or reminder field
ddb41dc chore: add test file to document_test_runner.dart
fcb2751 Merge branch 'main' into fix-current-time
fb201ee Merge branch 'main' into fix-current-time
f89bd98 Merge branch 'main' into fix-current-time
3aa74b3 Merge branch 'main' into fix-current-time
8c0a9c5 fix: flutter analyze

📊 Changes

4 files changed (+129 additions, -2 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_1.dart (+0 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart (+3 -0)
➕ frontend/appflowy_flutter/integration_test/desktop/document/document_with_date_reminder_test.dart (+125 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+1 -1)

📄 Description

closes : https://github.com/AppFlowy-IO/AppFlowy/issues/5219

https://github.com/user-attachments/assets/29085f2f-6232-4be6-8d38-54931b24cbaa

Feature Preview

I have fixed the the date set to 00:00 when the enabling the include time button. Since we are already having the time in the variable "parsedDate", and it was passed withoutTime, I removed this so whenever the time is enabled it will show same time as the time field in the DateTime Picker dialog

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6447 **Author:** [@Ahad-patel](https://github.com/Ahad-patel) **Created:** 10/1/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix-current-time` --- ### 📝 Commits (8) - [`66e6c21`](https://github.com/AppFlowy-IO/AppFlowy/commit/66e6c211021bb7f52e637d71b0e71f8f5c5c274c) fix: date issue when enbling time field - [`70e64dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/70e64dd1aae4cd668f2263a3118e4435013a34c0) chore: add integration test for date or reminder field - [`ddb41dc`](https://github.com/AppFlowy-IO/AppFlowy/commit/ddb41dc0182909f69bde0f60f609579d300d5238) chore: add test file to document_test_runner.dart - [`fcb2751`](https://github.com/AppFlowy-IO/AppFlowy/commit/fcb2751657fd0d4c54e8ddb976d77163fc94eb70) Merge branch 'main' into fix-current-time - [`fb201ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/fb201ee78748a875b21229965d14258c2ea24b91) Merge branch 'main' into fix-current-time - [`f89bd98`](https://github.com/AppFlowy-IO/AppFlowy/commit/f89bd98d228f83b01ab0f33d1ab7bbfae4650572) Merge branch 'main' into fix-current-time - [`3aa74b3`](https://github.com/AppFlowy-IO/AppFlowy/commit/3aa74b334934a484643fed38734c31dd0c0efcfa) Merge branch 'main' into fix-current-time - [`8c0a9c5`](https://github.com/AppFlowy-IO/AppFlowy/commit/8c0a9c5ff33af79fe95cf754e24c32a28c5772c3) fix: flutter analyze ### 📊 Changes **4 files changed** (+129 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_1.dart` (+0 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart` (+3 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/document/document_with_date_reminder_test.dart` (+125 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+1 -1) </details> ### 📄 Description  closes : https://github.com/AppFlowy-IO/AppFlowy/issues/5219  https://github.com/user-attachments/assets/29085f2f-6232-4be6-8d38-54931b24cbaa ### Feature Preview I have fixed the the date set to 00:00 when the enabling the include time button. Since we are already having the time in the variable "parsedDate", and it was passed withoutTime, I removed this so whenever the time is enabled it will show same time as the time field in the DateTime Picker dialog  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>