[PR #6461] [CLOSED] fix: unable to use undo/redo in title #7399

New issue

Closed

opened 2026-03-23 23:19:26 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6461
Author: @LucasXu0
Created: 10/3/2024
Status: ❌ Closed

Base: main ← Head: fix_launch_review_issues_071

📝 Commits (10+)

1b76743 chore: use native window drag on macOS
e68b0c6 fix: resizing the window causes the title to move around
662b106 fix: unable to use redo/undo in title
8b7f4e7 test: add redo/undo test
9593ef5 fix: deselect the title after pressing esc key
4568f00 test: add esc test in title
f893b43 chore: revert code
d7411c9 fix: redo test on Linux
a87f0b1 fix: ignore same icon update
b690887 test: add ignore same icon update test

📊 Changes

17 files changed (+268 additions, -28 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/workspace_icon_test.dart (+64 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/workspace_test_runner.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_title_test.dart (+82 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+13 -14)
📝 frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/core/frameless_window.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/mobile/application/page_style/document_page_style_bloc.dart (+11 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart (+13 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/application/document_bloc.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart (+17 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart (+9 -9)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shortcuts/command_shortcuts.dart (+4 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shortcuts/exit_edit_mode_command.dart (+24 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/undo_redo/custom_undo_redo_commands.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart (+8 -0)

📄 Description

Feature Preview

The editor catches the undo/redo command.

unable to use undo/redo in title
add test
deselect the title after pressing esc key
add test

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6461 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/3/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix_launch_review_issues_071` --- ### 📝 Commits (10+) - [`1b76743`](https://github.com/AppFlowy-IO/AppFlowy/commit/1b76743011696ff26ce60ab2567ee7ff328c5aa5) chore: use native window drag on macOS - [`e68b0c6`](https://github.com/AppFlowy-IO/AppFlowy/commit/e68b0c66dc7ce00bb72fba6fe3fcd23286bf65f0) fix: resizing the window causes the title to move around - [`662b106`](https://github.com/AppFlowy-IO/AppFlowy/commit/662b106636085721bbc50c37680980fbaba0ab67) fix: unable to use redo/undo in title - [`8b7f4e7`](https://github.com/AppFlowy-IO/AppFlowy/commit/8b7f4e7a16f34cfb38b15d9bdc63250b24c20bf5) test: add redo/undo test - [`9593ef5`](https://github.com/AppFlowy-IO/AppFlowy/commit/9593ef52d5547461a709cba8b19a3bfd9c42124d) fix: deselect the title after pressing esc key - [`4568f00`](https://github.com/AppFlowy-IO/AppFlowy/commit/4568f004692539b0065eed0cac68331ca075f8fc) test: add esc test in title - [`f893b43`](https://github.com/AppFlowy-IO/AppFlowy/commit/f893b43e78c74589cc6ba403c89f23f3a3ab0ccd) chore: revert code - [`d7411c9`](https://github.com/AppFlowy-IO/AppFlowy/commit/d7411c91e8fd7715e5efc353c3fc75397b16d959) fix: redo test on Linux - [`a87f0b1`](https://github.com/AppFlowy-IO/AppFlowy/commit/a87f0b145f49f0e7618a50239304a1bc0553b480) fix: ignore same icon update - [`b690887`](https://github.com/AppFlowy-IO/AppFlowy/commit/b690887f53d6d48b28d208c3f95c4a2f83f033b2) test: add ignore same icon update test ### 📊 Changes **17 files changed** (+268 additions, -28 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/workspace_icon_test.dart` (+64 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/workspace_test_runner.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_title_test.dart` (+82 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+13 -14) 📝 `frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/core/frameless_window.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/mobile/application/page_style/document_page_style_bloc.dart` (+11 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/show_mobile_bottom_sheet.dart` (+13 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page_header.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_bloc.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart` (+17 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart` (+9 -9) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shortcuts/command_shortcuts.dart` (+4 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shortcuts/exit_edit_mode_command.dart` (+24 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/undo_redo/custom_undo_redo_commands.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart` (+8 -0) </details> ### 📄 Description   ### Feature Preview The editor catches the undo/redo command. - [x] unable to use undo/redo in title - [x] add test - [x] deselect the title after pressing esc key - [x] add test  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>