[PR #6468] [MERGED] fix: ingore keyup event in cover title #7403

New issue

Closed

opened 2026-03-23 23:19:27 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6468
Author: @LucasXu0
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/4/2024
Merged by: @LucasXu0

Base: main ← Head: fix_cursor_in_title

📝 Commits (4)

6ec3920 fix: ingore keyup event in cover title
28a0100 feat: add text field with line metric
a9cd8fd chore: refactor test strcuture
96cd795 test: add arrow down key test

📊 Changes

10 files changed (+199 additions, -182 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart (+7 -17)
➖ frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_delete_block_test.dart (+0 -60)
➖ frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_drag_block_test.dart (+0 -101)
📝 frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_option_actions_test.dart (+45 -0)
➕ frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_test_runner.dart (+9 -0)
➕ frontend/appflowy_flutter/integration_test/desktop/cloud/uncategorized/uncategorized_test_runner.dart (+11 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/workspace_test_runner.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_title_test.dart (+28 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart (+10 -3)
➕ frontend/appflowy_flutter/lib/shared/text_field/text_filed_with_metric_lines.dart (+88 -0)

📄 Description

Feature Preview

the cursor flashes twice only with one down arrow at the last line of the title: first at the end of the title, second the beginning of the body.
add test

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6468 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/4/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_cursor_in_title` --- ### 📝 Commits (4) - [`6ec3920`](https://github.com/AppFlowy-IO/AppFlowy/commit/6ec3920c3d3b7d86f179a7a321757aec7becf401) fix: ingore keyup event in cover title - [`28a0100`](https://github.com/AppFlowy-IO/AppFlowy/commit/28a0100d07748e9a7addbc6c37dfad13db6ef92f) feat: add text field with line metric - [`a9cd8fd`](https://github.com/AppFlowy-IO/AppFlowy/commit/a9cd8fd021b5d1e2f31955cf83c47a44954f01d0) chore: refactor test strcuture - [`96cd795`](https://github.com/AppFlowy-IO/AppFlowy/commit/96cd79553bc225985ed55fc2c5cf12bce1a7c8b0) test: add arrow down key test ### 📊 Changes **10 files changed** (+199 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart` (+7 -17) ➖ `frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_delete_block_test.dart` (+0 -60) ➖ `frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_drag_block_test.dart` (+0 -101) 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_option_actions_test.dart` (+45 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_test_runner.dart` (+9 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/cloud/uncategorized/uncategorized_test_runner.dart` (+11 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/workspace_test_runner.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_title_test.dart` (+28 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart` (+10 -3) ➕ `frontend/appflowy_flutter/lib/shared/text_field/text_filed_with_metric_lines.dart` (+88 -0) </details> ### 📄 Description   ### Feature Preview - [x] the cursor flashes twice only with one down arrow at the last line of the title: first at the end of the title, second the beginning of the body. - [x] add test  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>