[PR #6479] [MERGED] fix: launch review issues #7410

Closed
opened 2026-03-23 23:19:30 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6479
Author: @richardshiue
Created: 10/4/2024
Status: Merged
Merged: 10/5/2024
Merged by: @richardshiue

Base: mainHead: fix/launch-review


📝 Commits (5)

  • ab30422 fix(flutter_desktop): field icon picker popover constraints
  • 0b23426 fix(mobile): immediately select field when editing filter
  • 955c31c fix: filter through select options not working
  • 7addb5c fix(mobile): scroll to bottom after filter creation
  • 138b1d5 fix: primary field tooltip

📊 Changes

5 files changed (+120 additions, -103 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_filter_bottom_sheet.dart (+80 -65)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_filter_bottom_sheet_cubit.dart (+8 -25)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart (+30 -12)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_icon_popup.dart (+1 -1)
📝 frontend/resources/translations/en.json (+1 -0)

📄 Description

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6479 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/5/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/launch-review` --- ### 📝 Commits (5) - [`ab30422`](https://github.com/AppFlowy-IO/AppFlowy/commit/ab3042295b8b6ea5df31666b439f56574c737bfe) fix(flutter_desktop): field icon picker popover constraints - [`0b23426`](https://github.com/AppFlowy-IO/AppFlowy/commit/0b2342676ec1c3608664aac0a545dd99f28d724c) fix(mobile): immediately select field when editing filter - [`955c31c`](https://github.com/AppFlowy-IO/AppFlowy/commit/955c31c73b5065dfe249756a6ea750af495ddab6) fix: filter through select options not working - [`7addb5c`](https://github.com/AppFlowy-IO/AppFlowy/commit/7addb5c43740382d426a24926e0f168c072dca32) fix(mobile): scroll to bottom after filter creation - [`138b1d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/138b1d5c8dbef6c304cde42352943f4beac6493a) fix: primary field tooltip ### 📊 Changes **5 files changed** (+120 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_filter_bottom_sheet.dart` (+80 -65) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_filter_bottom_sheet_cubit.dart` (+8 -25) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart` (+30 -12) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_icon_popup.dart` (+1 -1) 📝 `frontend/resources/translations/en.json` (+1 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:30 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7410
No description provided.