[PR #6475] [MERGED] fix: Grid new row getting cut #7413

New issue

Closed

opened 2026-03-23 23:19:30 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6475
Author: @Ahad-patel
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/10/2024
Merged by: @Xazin

Base: main ← Head: fix-grid-cell-visibility

📝 Commits (5)

49d13ef fix: Grid new row getting cut
13df6ba chore: add test case for testing text in veiwport
9c34458 Merge branch 'main' into fix-grid-cell-visibility
c310a7e refac: clean up code
3a39634 Merge branch 'main' into fix-grid-cell-visibility

📊 Changes

3 files changed (+100 additions, -59 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart (+27 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart (+71 -56)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/footer/grid_footer.dart (+2 -1)

📄 Description

closes : #6330

Feature Preview

I have replaced stack with column in _renderList, as when the CalculationsRow are moved from the viewport the _PositionedCalculationsRow are stacked on top of the ReorderableListView which was hiding the text rows below, so I moved them in column and removed position widget from both ReorderableListView and _PositionedCalculationsRow and expanded the ReorderableListView so it aquired all the availiable space of the window

https://github.com/user-attachments/assets/5fe04031-da28-414a-b264-39e830e37291

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6475 **Author:** [@Ahad-patel](https://github.com/Ahad-patel) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix-grid-cell-visibility` --- ### 📝 Commits (5) - [`49d13ef`](https://github.com/AppFlowy-IO/AppFlowy/commit/49d13eff512db027375c019b4840a99198a7ade0) fix: Grid new row getting cut - [`13df6ba`](https://github.com/AppFlowy-IO/AppFlowy/commit/13df6badc21066afb0a9d0ef8e854f2ce0ee8f4b) chore: add test case for testing text in veiwport - [`9c34458`](https://github.com/AppFlowy-IO/AppFlowy/commit/9c344580d95c0ec0aacfa66033f1e2e3ca31843f) Merge branch 'main' into fix-grid-cell-visibility - [`c310a7e`](https://github.com/AppFlowy-IO/AppFlowy/commit/c310a7e8080346de2168ea1c1d4dd2fa46b78556) refac: clean up code - [`3a39634`](https://github.com/AppFlowy-IO/AppFlowy/commit/3a396343071870c7e7f077e188d433fe13e78949) Merge branch 'main' into fix-grid-cell-visibility ### 📊 Changes **3 files changed** (+100 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart` (+27 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/grid_page.dart` (+71 -56) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/footer/grid_footer.dart` (+2 -1) </details> ### 📄 Description  closes : #6330  ### Feature Preview I have replaced stack with column in _renderList, as when the CalculationsRow are moved from the viewport the _PositionedCalculationsRow are stacked on top of the ReorderableListView which was hiding the text rows below, so I moved them in column and removed position widget from both ReorderableListView and _PositionedCalculationsRow and expanded the ReorderableListView so it aquired all the availiable space of the window  https://github.com/user-attachments/assets/5fe04031-da28-414a-b264-39e830e37291  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>