[PR #6489] [MERGED] Fix calculation bug #7415

Closed
opened 2026-03-23 23:19:31 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6489
Author: @appflowy
Created: 10/6/2024
Status: Merged
Merged: 10/7/2024
Merged by: @appflowy

Base: mainHead: fix_calculation_bug


📝 Commits (7)

  • bec1668 chore: upgrade collab
  • 90cf10e fix: calculate value
  • 1ba339f chore: optimize calculate
  • e714548 chore: cal when open database
  • 3b696e4 Merge branch 'main' into fix_calculation_bug
  • ea34b22 chore: update calculation when filter change
  • 64dfad2 chore: use same runtime

📊 Changes

16 files changed (+346 additions, -288 deletions)

View changed files

📝 frontend/rust-lib/dart-ffi/src/lib.rs (+3 -3)
📝 frontend/rust-lib/flowy-database2/src/entities/calculation/calculation_entities.rs (+13 -0)
📝 frontend/rust-lib/flowy-database2/src/services/calculations/controller.rs (+113 -64)
📝 frontend/rust-lib/flowy-database2/src/services/calculations/entities.rs (+0 -15)
📝 frontend/rust-lib/flowy-database2/src/services/calculations/service.rs (+79 -125)
📝 frontend/rust-lib/flowy-database2/src/services/calculations/task.rs (+12 -13)
📝 frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs (+14 -9)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_calculations.rs (+11 -5)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs (+44 -7)
📝 frontend/rust-lib/flowy-database2/src/services/database_view/view_operation.rs (+1 -1)
📝 frontend/rust-lib/flowy-database2/src/services/filter/controller.rs (+6 -5)
📝 frontend/rust-lib/flowy-database2/src/services/filter/task.rs (+11 -11)
📝 frontend/rust-lib/flowy-database2/src/services/sort/controller.rs (+1 -0)
📝 frontend/rust-lib/flowy-database2/src/services/sort/task.rs (+13 -13)
📝 frontend/rust-lib/lib-infra/src/priority_task/scheduler.rs (+15 -6)
📝 frontend/rust-lib/lib-infra/tests/task_test/script.rs (+10 -11)

📄 Description

  1. fix calcualte values are wrong when applying filter. The values are not changed after creating a new filter.
  2. update calcualte values after filter change. The values are not changed after editing filter

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6489 **Author:** [@appflowy](https://github.com/appflowy) **Created:** 10/6/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix_calculation_bug` --- ### 📝 Commits (7) - [`bec1668`](https://github.com/AppFlowy-IO/AppFlowy/commit/bec1668272d2aa137344f8f07b423729f754963d) chore: upgrade collab - [`90cf10e`](https://github.com/AppFlowy-IO/AppFlowy/commit/90cf10e2c465c3721cda41b5eb5e0d164f64dedb) fix: calculate value - [`1ba339f`](https://github.com/AppFlowy-IO/AppFlowy/commit/1ba339fabee8420d9e2c5f7c6a1feae77e056c5d) chore: optimize calculate - [`e714548`](https://github.com/AppFlowy-IO/AppFlowy/commit/e714548dc3decaecf9fe787b81aa3a6017f035b2) chore: cal when open database - [`3b696e4`](https://github.com/AppFlowy-IO/AppFlowy/commit/3b696e4d271ac241d79b67e9e848fd1153138e83) Merge branch 'main' into fix_calculation_bug - [`ea34b22`](https://github.com/AppFlowy-IO/AppFlowy/commit/ea34b226f1e971a55118dcd7c1b55b813f233715) chore: update calculation when filter change - [`64dfad2`](https://github.com/AppFlowy-IO/AppFlowy/commit/64dfad284e866a24c923e99c1f520ddfc89aef78) chore: use same runtime ### 📊 Changes **16 files changed** (+346 additions, -288 deletions) <details> <summary>View changed files</summary> 📝 `frontend/rust-lib/dart-ffi/src/lib.rs` (+3 -3) 📝 `frontend/rust-lib/flowy-database2/src/entities/calculation/calculation_entities.rs` (+13 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/calculations/controller.rs` (+113 -64) 📝 `frontend/rust-lib/flowy-database2/src/services/calculations/entities.rs` (+0 -15) 📝 `frontend/rust-lib/flowy-database2/src/services/calculations/service.rs` (+79 -125) 📝 `frontend/rust-lib/flowy-database2/src/services/calculations/task.rs` (+12 -13) 📝 `frontend/rust-lib/flowy-database2/src/services/database/database_editor.rs` (+14 -9) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_calculations.rs` (+11 -5) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs` (+44 -7) 📝 `frontend/rust-lib/flowy-database2/src/services/database_view/view_operation.rs` (+1 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/filter/controller.rs` (+6 -5) 📝 `frontend/rust-lib/flowy-database2/src/services/filter/task.rs` (+11 -11) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/controller.rs` (+1 -0) 📝 `frontend/rust-lib/flowy-database2/src/services/sort/task.rs` (+13 -13) 📝 `frontend/rust-lib/lib-infra/src/priority_task/scheduler.rs` (+15 -6) 📝 `frontend/rust-lib/lib-infra/tests/task_test/script.rs` (+10 -11) </details> ### 📄 Description 1. fix calcualte values are wrong when applying filter. The values are not changed after creating a new filter. 2. update calcualte values after filter change. The values are not changed after editing filter --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:31 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7415
No description provided.