[PR #6487] [MERGED] fix: share button doesn't response under macOS 15 #7417

New issue

Closed

opened 2026-03-23 23:19:31 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6487
Author: @LucasXu0
Created: 10/5/2024
Status: ✅ Merged
Merged: 10/7/2024
Merged by: @LucasXu0

Base: main ← Head: share_button_not_response

📝 Commits (4)

d35a616 fix: share button doesn't response under macos 15
32c49c9 chore: enable macos integration test
391870d Revert "chore: enable macos integration test"
29f4a95 chore: update comment

📊 Changes

3 files changed (+27 additions, -3 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/frameless_window.dart (+10 -3)
📝 frontend/appflowy_flutter/lib/startup/tasks/device_info_task.dart (+10 -0)
📝 frontend/appflowy_flutter/macos/Runner/MainFlutterWindow.swift (+7 -0)

📄 Description

Feature Preview

Only enable window tiling and disable the frameless window feature if the macOS version is 10.15 or higher.

We do have the share test, but it only runs on Linux now. So this issue wasn't captured by the test.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6487 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/5/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `share_button_not_response` --- ### 📝 Commits (4) - [`d35a616`](https://github.com/AppFlowy-IO/AppFlowy/commit/d35a616ec2113a0d2f85fc323c0d233e9610e331) fix: share button doesn't response under macos 15 - [`32c49c9`](https://github.com/AppFlowy-IO/AppFlowy/commit/32c49c9f36c9d41086fbe44d7006b872ed850505) chore: enable macos integration test - [`391870d`](https://github.com/AppFlowy-IO/AppFlowy/commit/391870d26ce150957777b1fceb6dfde25c40419a) Revert "chore: enable macos integration test" - [`29f4a95`](https://github.com/AppFlowy-IO/AppFlowy/commit/29f4a95dfa16701dc2401d93ef5b74cae8b8cda7) chore: update comment ### 📊 Changes **3 files changed** (+27 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/frameless_window.dart` (+10 -3) 📝 `frontend/appflowy_flutter/lib/startup/tasks/device_info_task.dart` (+10 -0) 📝 `frontend/appflowy_flutter/macos/Runner/MainFlutterWindow.swift` (+7 -0) </details> ### 📄 Description   ### Feature Preview Only enable window tiling and disable the frameless window feature if the macOS version is 10.15 or higher. We do have the share test, but it only runs on Linux now. So this issue wasn't captured by the test.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>