[PR #6495] [MERGED] fix: potential text empty when editing doc #7421

New issue

Closed

opened 2026-03-23 23:19:32 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6495
Author: @LucasXu0
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/7/2024
Merged by: @appflowy

Base: main ← Head: fix_potential_text_empty

📝 Commits (1)

be7a83a fix: fix potential text empty when editing doc

📊 Changes

3 files changed (+180 additions, -26 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/application/document_bloc.dart (+42 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart (+63 -20)
📝 frontend/appflowy_flutter/test/unit_test/editor/transaction_adapter_test.dart (+75 -1)

📄 Description

Feature Preview

depends on https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/305

If the paragraph in the document wasn't already associated with an external ID and external type, when editing it, the adapter should assign it a new external ID and external type using the existing data.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6495 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `fix_potential_text_empty` --- ### 📝 Commits (1) - [`be7a83a`](https://github.com/AppFlowy-IO/AppFlowy/commit/be7a83a9f5f61fbbaae508b122caf89927cd48f3) fix: fix potential text empty when editing doc ### 📊 Changes **3 files changed** (+180 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/application/document_bloc.dart` (+42 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart` (+63 -20) 📝 `frontend/appflowy_flutter/test/unit_test/editor/transaction_adapter_test.dart` (+75 -1) </details> ### 📄 Description   ### Feature Preview depends on https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/305 If the paragraph in the document wasn't already associated with an external ID and external type, when editing it, the adapter should assign it a new external ID and external type using the existing data.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>