[PR #6501] [MERGED] feat: support editing name when creating a new page on mobile #7424

Closed
opened 2026-03-23 23:19:33 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6501
Author: @LucasXu0
Created: 10/7/2024
Status: Merged
Merged: 10/8/2024
Merged by: @LucasXu0

Base: mainHead: support_editing_name_when_creating_page_on_mobile


📝 Commits (8)

  • b9f55a8 feat: support editing name when creating a new page on mobile
  • f98b8de chore: add defaultName in layout extension
  • 53bd6eb test: add cover title test on mobile
  • 8b24917 fix: cover title test on mobile
  • a6f0051 feat: add integration runner 4
  • 73d69ff Merge branch 'main' into support_editing_name_when_creating_page_on_mobile
  • d4e38d5 chore: update translations
  • a55e229 chore: disable subpage feature

📊 Changes

28 files changed (+306 additions, -125 deletions)

View changed files

📝 .github/actions/flutter_integration_test/action.yml (+2 -2)
📝 .github/workflows/flutter_ci.yaml (+39 -33)
📝 .github/workflows/release.yml (+1 -1)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_1.dart (+3 -1)
frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart (+14 -0)
📝 frontend/appflowy_flutter/integration_test/desktop_runner_1.dart (+3 -3)
📝 frontend/appflowy_flutter/integration_test/desktop_runner_3.dart (+3 -8)
frontend/appflowy_flutter/integration_test/desktop_runner_4.dart (+17 -0)
frontend/appflowy_flutter/integration_test/mobile/document/document_test_runner.dart (+12 -0)
frontend/appflowy_flutter/integration_test/mobile/document/title_test.dart (+76 -0)
📝 frontend/appflowy_flutter/integration_test/runner.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+8 -12)
📝 frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart (+9 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/default_mobile_action_pane.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/tab/mobile_space_tab.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/mobile/presentation/mobile_bottom_navigation_bar.dart (+34 -16)
📝 frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+4 -4)

...and 8 more files

📄 Description

Feature Preview

  • support editing the title after creating a new doc on mobile
  • test

https://github.com/user-attachments/assets/ce9b7b44-31aa-4682-93f0-98df0979f7fc


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6501 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/8/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `support_editing_name_when_creating_page_on_mobile` --- ### 📝 Commits (8) - [`b9f55a8`](https://github.com/AppFlowy-IO/AppFlowy/commit/b9f55a8a472a91181f8eaa6131a2dde8c4e1e2eb) feat: support editing name when creating a new page on mobile - [`f98b8de`](https://github.com/AppFlowy-IO/AppFlowy/commit/f98b8de1d6f2d516bce075e8da4c35776bf2bc66) chore: add defaultName in layout extension - [`53bd6eb`](https://github.com/AppFlowy-IO/AppFlowy/commit/53bd6ebbd9178a7e7d0885c75c3e083ee3135d8d) test: add cover title test on mobile - [`8b24917`](https://github.com/AppFlowy-IO/AppFlowy/commit/8b249178a52a7b9874d5b408e16464c347b7cbb1) fix: cover title test on mobile - [`a6f0051`](https://github.com/AppFlowy-IO/AppFlowy/commit/a6f005114d3ffcddf6fcb90ee7c9d73ba030f69b) feat: add integration runner 4 - [`73d69ff`](https://github.com/AppFlowy-IO/AppFlowy/commit/73d69ff93c3694127546decb5abc9320273fe916) Merge branch 'main' into support_editing_name_when_creating_page_on_mobile - [`d4e38d5`](https://github.com/AppFlowy-IO/AppFlowy/commit/d4e38d5f2a65fabd0224f58a851fe97bbc480a13) chore: update translations - [`a55e229`](https://github.com/AppFlowy-IO/AppFlowy/commit/a55e229cf538f1b82d0b610c88238d54a3ed0f05) chore: disable subpage feature ### 📊 Changes **28 files changed** (+306 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/flutter_integration_test/action.yml` (+2 -2) 📝 `.github/workflows/flutter_ci.yaml` (+39 -33) 📝 `.github/workflows/release.yml` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_1.dart` (+3 -1) ➕ `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart` (+14 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop_runner_1.dart` (+3 -3) 📝 `frontend/appflowy_flutter/integration_test/desktop_runner_3.dart` (+3 -8) ➕ `frontend/appflowy_flutter/integration_test/desktop_runner_4.dart` (+17 -0) ➕ `frontend/appflowy_flutter/integration_test/mobile/document/document_test_runner.dart` (+12 -0) ➕ `frontend/appflowy_flutter/integration_test/mobile/document/title_test.dart` (+76 -0) 📝 `frontend/appflowy_flutter/integration_test/runner.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+8 -12) 📝 `frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart` (+9 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/default_mobile_action_pane.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/tab/mobile_space_tab.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/mobile_bottom_navigation_bar.dart` (+34 -16) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/page_item/mobile_view_item.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+4 -4) _...and 8 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] support editing the title after creating a new doc on mobile - [x] test https://github.com/user-attachments/assets/ce9b7b44-31aa-4682-93f0-98df0979f7fc <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:33 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7424
No description provided.