[PR #6515] [MERGED] feat: checklist cell improvements #7433

Closed
opened 2026-03-23 23:19:35 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6515
Author: @richardshiue
Created: 10/9/2024
Status: Merged
Merged: 10/10/2024
Merged by: @richardshiue

Base: mainHead: feat/reorder-checklist


📝 Commits (7)

  • 098d31b feat: reorder checklist tasks
  • 2727e16 feat: quickly create checklist tasks
  • ae65a86 feat: reorder checklist on mobile
  • 54b3c36 test: add integration test
  • c7fa365 test: add bloc test
  • 9bdc45e fix: flutter analyzer
  • 850d9c2 fix: cargo clippy

📊 Changes

32 files changed (+1251 additions, -465 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_row_page_test.dart (+138 -1)
📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+22 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/checklist_cell_bloc.dart (+92 -11)
📝 frontend/appflowy_flutter/lib/plugins/database/domain/checklist_cell_service.dart (+37 -22)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_checklist_cell.dart (+14 -11)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart (+303 -94)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/checklist.dart (+5 -11)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_checklist_cell.dart (+30 -27)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_checklist_cell.dart (+42 -39)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart (+114 -43)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_textfield.dart (+9 -9)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_checklist_cell_editor.dart (+83 -47)
frontend/appflowy_flutter/test/bloc_test/grid_test/cell/checklist_cell_bloc_test.dart (+154 -0)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/cell/select_option_cell_test.dart (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/cell/text_cell_bloc_test.dart (+5 -5)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/field/field_cell_bloc_test.dart (+2 -2)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/field/field_editor_bloc_test.dart (+1 -1)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_editor_bloc_test.dart (+6 -6)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/sort/sort_editor_bloc_test.dart (+3 -3)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/util.dart (+2 -0)

...and 12 more files

📄 Description

resolves https://github.com/AppFlowy-IO/AppFlowy/issues/6254
resolves https://github.com/AppFlowy-IO/AppFlowy/issues/5793
resolves https://github.com/AppFlowy-IO/AppFlowy/issues/5896

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6515 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/9/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/reorder-checklist` --- ### 📝 Commits (7) - [`098d31b`](https://github.com/AppFlowy-IO/AppFlowy/commit/098d31bdf4761f4615af7512b7cd76a5e95041b0) feat: reorder checklist tasks - [`2727e16`](https://github.com/AppFlowy-IO/AppFlowy/commit/2727e1669845bfed0ef857b94d4a99a27d65bd6a) feat: quickly create checklist tasks - [`ae65a86`](https://github.com/AppFlowy-IO/AppFlowy/commit/ae65a869e9f1ad9ef82378d9736e11e598c7a3c2) feat: reorder checklist on mobile - [`54b3c36`](https://github.com/AppFlowy-IO/AppFlowy/commit/54b3c36f5706abdca88131a2e6d07d5e678c370c) test: add integration test - [`c7fa365`](https://github.com/AppFlowy-IO/AppFlowy/commit/c7fa365bab874be4f92a625d23fb4630addc0dd1) test: add bloc test - [`9bdc45e`](https://github.com/AppFlowy-IO/AppFlowy/commit/9bdc45ecd022d63ca5b04d41efba350565a06202) fix: flutter analyzer - [`850d9c2`](https://github.com/AppFlowy-IO/AppFlowy/commit/850d9c2d7f9e780f0c29810484356a489497720b) fix: cargo clippy ### 📊 Changes **32 files changed** (+1251 additions, -465 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_row_page_test.dart` (+138 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+22 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/checklist_cell_bloc.dart` (+92 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database/domain/checklist_cell_service.dart` (+37 -22) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_checklist_cell.dart` (+14 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart` (+303 -94) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/editable_cell_skeleton/checklist.dart` (+5 -11) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_grid/mobile_grid_checklist_cell.dart` (+30 -27) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/mobile_row_detail/mobile_row_detail_checklist_cell.dart` (+42 -39) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart` (+114 -43) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_textfield.dart` (+9 -9) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/mobile_checklist_cell_editor.dart` (+83 -47) ➕ `frontend/appflowy_flutter/test/bloc_test/grid_test/cell/checklist_cell_bloc_test.dart` (+154 -0) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/cell/select_option_cell_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/cell/text_cell_bloc_test.dart` (+5 -5) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/field/field_cell_bloc_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/field/field_editor_bloc_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_editor_bloc_test.dart` (+6 -6) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/sort/sort_editor_bloc_test.dart` (+3 -3) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/util.dart` (+2 -0) _...and 12 more files_ </details> ### 📄 Description resolves https://github.com/AppFlowy-IO/AppFlowy/issues/6254 resolves https://github.com/AppFlowy-IO/AppFlowy/issues/5793 resolves https://github.com/AppFlowy-IO/AppFlowy/issues/5896 ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:35 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7433
No description provided.