[PR #6530] [CLOSED] [WIP] test: filter calculations #7443

New issue

Closed

opened 2026-03-23 23:19:38 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6530
Author: @Xazin
Created: 10/10/2024
Status: ❌ Closed

Base: main ← Head: test/filter-calculations

📝 Commits (7)

61b6629 test: filter+calculations
398a901 test: add more coverage
79c186f test: fix failing test after merge
89b4e33 test: add expects back
c590d59 chore: merge branch 'upstream/main' into test/filter-calculations
826170e test: add duration to pump to check
d110e94 chore: merge branch 'upstream/main' into test/filter-calculations

📊 Changes

5 files changed (+650 additions, -43 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/grid/grid_calculations_test.dart (+575 -5)
📝 frontend/appflowy_flutter/integration_test/desktop_runner_4.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+19 -5)
📝 frontend/appflowy_flutter/lib/plugins/database/application/calculations/calculations_service.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculate_cell.dart (+54 -31)

📄 Description

There is a bug that needs to be resolved, the regression test has been added but with the expects commented out at the moment.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6530 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/10/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test/filter-calculations` --- ### 📝 Commits (7) - [`61b6629`](https://github.com/AppFlowy-IO/AppFlowy/commit/61b66291cb8cd567f4843699dffba5be75b5cb20) test: filter+calculations - [`398a901`](https://github.com/AppFlowy-IO/AppFlowy/commit/398a9010bf00f9a042ea82831488b7ee961db971) test: add more coverage - [`79c186f`](https://github.com/AppFlowy-IO/AppFlowy/commit/79c186fa9997328ae71317830176b87ff4fc2f97) test: fix failing test after merge - [`89b4e33`](https://github.com/AppFlowy-IO/AppFlowy/commit/89b4e334fb31ade24feffc30a3033b288d8be9bb) test: add expects back - [`c590d59`](https://github.com/AppFlowy-IO/AppFlowy/commit/c590d59ed58aa0686215ee2af5f37720800851c8) chore: merge branch 'upstream/main' into test/filter-calculations - [`826170e`](https://github.com/AppFlowy-IO/AppFlowy/commit/826170e1109c5e5b5bba6095f4f6f07b29f4580d) test: add duration to pump to check - [`d110e94`](https://github.com/AppFlowy-IO/AppFlowy/commit/d110e9446ef004c240760220a67a403c6ecd81a0) chore: merge branch 'upstream/main' into test/filter-calculations ### 📊 Changes **5 files changed** (+650 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/grid/grid_calculations_test.dart` (+575 -5) 📝 `frontend/appflowy_flutter/integration_test/desktop_runner_4.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+19 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/calculations/calculations_service.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/calculations/calculate_cell.dart` (+54 -31) </details> ### 📄 Description There is a bug that needs to be resolved, the regression test has been added but with the expects commented out at the moment. #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>