[PR #6541] [CLOSED] feat: support navigate to block #7447

Closed
opened 2026-03-23 23:19:39 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6541
Author: @LucasXu0
Created: 10/14/2024
Status: Closed

Base: mainHead: navigate_to_block


📝 Commits (5)

  • 2ac8cab feat: support navigate to block
  • cc2f659 fix: text overflow and integration tests
  • 72c803e Merge branch 'main' into navigate_to_block
  • f69d79f test: navigate to block test
  • 08c3757 Merge branch 'main' into navigate_to_block

📊 Changes

8 files changed (+148 additions, -25 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_copy_link_to_block_test.dart (+22 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document.dart (+9 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+77 -13)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart (+22 -9)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+9 -3)
📝 frontend/appflowy_flutter/lib/workspace/application/action_navigation/navigation_action.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+5 -0)

📄 Description

Feature Preview

- [x] Navigate to the block if the share link contains block_id
- [ ] Support scroll position: top, middle, bottom
- [x] Tests

Improper implementation


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6541 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/14/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `navigate_to_block` --- ### 📝 Commits (5) - [`2ac8cab`](https://github.com/AppFlowy-IO/AppFlowy/commit/2ac8cab17f24a4ae28871b5f7fbae9ca3419d39b) feat: support navigate to block - [`cc2f659`](https://github.com/AppFlowy-IO/AppFlowy/commit/cc2f6598ef8b3ff6a9e18f77d8f341c6b6d8184e) fix: text overflow and integration tests - [`72c803e`](https://github.com/AppFlowy-IO/AppFlowy/commit/72c803e864339ea3cf13abdb46a31687baccb53f) Merge branch 'main' into navigate_to_block - [`f69d79f`](https://github.com/AppFlowy-IO/AppFlowy/commit/f69d79f26d728d3b214a0a9757de406a23c6231a) test: navigate to block test - [`08c3757`](https://github.com/AppFlowy-IO/AppFlowy/commit/08c37574bdce71e1508def1055ea439b4aea8ac7) Merge branch 'main' into navigate_to_block ### 📊 Changes **8 files changed** (+148 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_copy_link_to_block_test.dart` (+22 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document.dart` (+9 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+77 -13) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart` (+22 -9) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+9 -3) 📝 `frontend/appflowy_flutter/lib/workspace/application/action_navigation/navigation_action.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+5 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview ~~- [x] Navigate to the block if the share link contains `block_id`~~ ~~- [ ] Support scroll position: top, middle, bottom~~ ~~- [x] Tests~~ Improper implementation <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:39 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7447
No description provided.