[PR #6567] [MERGED] feat: inline sub page mention #7462

New issue

Closed

opened 2026-03-23 23:19:43 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6567
Author: @Xazin
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @LucasXu0

Base: main ← Head: feat/inline-child-page-mention

📝 Commits (10+)

d80bd6f feat: inline sub page mention
09f312d fix: disable editing documents in trash
62c1740 fix: duplicate block behavior
97c1a1c refactor: clean up code
9e99ac1 feat: use formatText function instead of modify delta manually
b3f3c31 fix: paste behavior format mention
a813237 fix: default icon for mentioned pages
62bcf43 fix: view new parent turn into page reference
b0c142a chore: merge branch 'upstream/main' into feat/inline-child-page-mention
dafbba4 test: add base test

📊 Changes

33 files changed (+2004 additions, -491 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/desktop/document/document_inline_sub_page_test.dart (+378 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart (+2 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+37 -0)
📝 frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+10 -128)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart (+4 -43)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/page_reference_commands.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_cut_command.dart (+9 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_paste_command.dart (+76 -74)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart (+1 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart (+230 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart (+18 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_bloc.dart (+109 -96)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart (+286 -103)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shared_context/shared_context.dart (+1 -8)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_transaction_handler.dart (+245 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/block_transaction_handler.dart (+13 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_handler.dart (+37 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart (+306 -0)

...and 13 more files

📄 Description

Relates: #5692 #5417 #5134

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6567 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `feat/inline-child-page-mention` --- ### 📝 Commits (10+) - [`d80bd6f`](https://github.com/AppFlowy-IO/AppFlowy/commit/d80bd6fec05ed36d26432b0a76701e08d3c51527) feat: inline sub page mention - [`09f312d`](https://github.com/AppFlowy-IO/AppFlowy/commit/09f312d512a55c92768723145c882c03a05a1b14) fix: disable editing documents in trash - [`62c1740`](https://github.com/AppFlowy-IO/AppFlowy/commit/62c174039b9dc3fbf501d21eddfee39a7df762e2) fix: duplicate block behavior - [`97c1a1c`](https://github.com/AppFlowy-IO/AppFlowy/commit/97c1a1c5b765ec582be51b96065e41afde6ca12e) refactor: clean up code - [`9e99ac1`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e99ac1ca48ac73183c3b8a3d76744433845c348) feat: use formatText function instead of modify delta manually - [`b3f3c31`](https://github.com/AppFlowy-IO/AppFlowy/commit/b3f3c31b2775e4e16b461e5d0358b57b672266e5) fix: paste behavior format mention - [`a813237`](https://github.com/AppFlowy-IO/AppFlowy/commit/a813237cc4a33ce9262fd69079521047c5e842cf) fix: default icon for mentioned pages - [`62bcf43`](https://github.com/AppFlowy-IO/AppFlowy/commit/62bcf4325defeea76b84c69ba235da4685cf8731) fix: view new parent turn into page reference - [`b0c142a`](https://github.com/AppFlowy-IO/AppFlowy/commit/b0c142a98a7bcb62fdf9e60e3b35a9f12584e0ba) chore: merge branch 'upstream/main' into feat/inline-child-page-mention - [`dafbba4`](https://github.com/AppFlowy-IO/AppFlowy/commit/dafbba48ef691ab49c5f638d49c8db159ffc0bf6) test: add base test ### 📊 Changes **33 files changed** (+2004 additions, -491 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/desktop/document/document_inline_sub_page_test.dart` (+378 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart` (+2 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+37 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+10 -128) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart` (+4 -43) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/page_reference_commands.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_cut_command.dart` (+9 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/custom_paste_command.dart` (+76 -74) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart` (+1 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart` (+230 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart` (+18 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_bloc.dart` (+109 -96) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart` (+286 -103) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shared_context/shared_context.dart` (+1 -8) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_transaction_handler.dart` (+245 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/block_transaction_handler.dart` (+13 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_handler.dart` (+37 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart` (+306 -0) _...and 13 more files_ </details> ### 📄 Description Relates: #5692 #5417 #5134 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>