[PR #6568] [MERGED] feat: observe mention block change and support block navigation #7463

Closed
opened 2026-03-23 23:19:44 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6568
Author: @LucasXu0
Created: 10/17/2024
Status: Merged
Merged: 10/17/2024
Merged by: @LucasXu0

Base: mainHead: mention_block_change_and_navigation


📝 Commits (7)

  • a94e9ac feat: observe mentioned block changes and navigate to block
  • 4d6d806 test: add delete mentioned block test
  • ac67626 chore: update editor version
  • f5c7aba feat: navigate block in same page
  • 59993e0 fix: sometimes turn into menu doesn't work
  • d85d4e9 test: add test
  • 45fa642 fix: integration test

📊 Changes

14 files changed (+296 additions, -34 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_copy_link_to_block_test.dart (+102 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document.dart (+9 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+77 -13)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+8 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_button.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/draggable_option_button.dart (+6 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart (+70 -11)
📝 frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart (+9 -3)
📝 frontend/appflowy_flutter/lib/workspace/application/action_navigation/navigation_action.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart (+5 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/account_deletion.dart (+0 -2)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)

📄 Description

Feature Preview

https://github.com/user-attachments/assets/d00e0555-e491-498d-9398-235dc4170a53

  • navigate to a block by block_id
  • observe the block content change
    • the block from the same page
    • the block from another page
  • tests

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6568 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `mention_block_change_and_navigation` --- ### 📝 Commits (7) - [`a94e9ac`](https://github.com/AppFlowy-IO/AppFlowy/commit/a94e9ac4c580a61d64dd06678e00051c2b652fe5) feat: observe mentioned block changes and navigate to block - [`4d6d806`](https://github.com/AppFlowy-IO/AppFlowy/commit/4d6d806d1a98996acd0e8b9b7fc0c42c2b8115fa) test: add delete mentioned block test - [`ac67626`](https://github.com/AppFlowy-IO/AppFlowy/commit/ac676267636ed8df456176da8210b2a1083e8255) chore: update editor version - [`f5c7aba`](https://github.com/AppFlowy-IO/AppFlowy/commit/f5c7aba2e13e058524a969e1292c2c023d580939) feat: navigate block in same page - [`59993e0`](https://github.com/AppFlowy-IO/AppFlowy/commit/59993e094d0706c8f6b27b665c3dec3a1abf09fb) fix: sometimes turn into menu doesn't work - [`d85d4e9`](https://github.com/AppFlowy-IO/AppFlowy/commit/d85d4e9fda8d22ab1c610d8bbabb3c3fc6541a8b) test: add test - [`45fa642`](https://github.com/AppFlowy-IO/AppFlowy/commit/45fa642190788c189904a064d8449024a60d104d) fix: integration test ### 📊 Changes **14 files changed** (+296 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/document/document_copy_link_to_block_test.dart` (+102 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document.dart` (+9 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+77 -13) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+8 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_button.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/draggable_option_button.dart` (+6 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart` (+70 -11) 📝 `frontend/appflowy_flutter/lib/startup/tasks/app_widget.dart` (+9 -3) 📝 `frontend/appflowy_flutter/lib/workspace/application/action_navigation/navigation_action.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/sidebar.dart` (+5 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/account/account_deletion.dart` (+0 -2) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview https://github.com/user-attachments/assets/d00e0555-e491-498d-9398-235dc4170a53 - [x] navigate to a block by block_id - [x] observe the block content change - [x] the block from the same page - [x] the block from another page - [x] tests <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:44 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7463
No description provided.