[PR #6576] [MERGED] fix: turn into issues #7465

New issue

Closed

opened 2026-03-23 23:19:45 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6576
Author: @LucasXu0
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/18/2024
Merged by: @LucasXu0

Base: main ← Head: fix_option_button_issues

📝 Commits (10+)

2dfa9d9 fix: cover title issues
3f5e46a fix: the selection should be cleared if selecting child node
cafbc50 fix: exclude the blocks that are not supported in the 'turn into' types
581fb2c fix: add logs
8b8fff9 fix: floating toolbar ai status
ca3f225 test: selecting the parent should deselect all the child nodes as well
8ca7c56 chore: 'Copy Link' to 'Copy link'
c417a94 fix: select all and turn into block doesn't work on Windows
b4872a4 test: calculate turn into selection test
98305ff fix: option button tests

📊 Changes

12 files changed (+661 additions, -294 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_option_action_test.dart (+33 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_1.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart (+35 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/draggable_option_button.dart (+5 -262)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/draggable_option_button_feedback.dart (+266 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/option_button.dart (+138 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/cover_title_command.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/smart_edit_toolbar_item.dart (+17 -17)
📝 frontend/appflowy_flutter/pubspec.lock (+6 -6)
📝 frontend/appflowy_flutter/test/unit_test/document/turn_into/turn_into_test.dart (+150 -0)
📝 frontend/resources/translations/en.json (+3 -3)

📄 Description

Feature Preview

selecting the parent should deselect all the child nodes as well.
test: selecting the parent should deselect all the child nodes as well.
the inline mention style doesn’t support on mobile.
test: the inline mention style doesn’t support on mobile.

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6576 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/18/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_option_button_issues` --- ### 📝 Commits (10+) - [`2dfa9d9`](https://github.com/AppFlowy-IO/AppFlowy/commit/2dfa9d934d755a767298b91b4baba79151ce8b0d) fix: cover title issues - [`3f5e46a`](https://github.com/AppFlowy-IO/AppFlowy/commit/3f5e46accb7a2220f3a7c148680f4227e9ba3724) fix: the selection should be cleared if selecting child node - [`cafbc50`](https://github.com/AppFlowy-IO/AppFlowy/commit/cafbc504793d6c5d4a32ae5ad4ebad1ab82661ef) fix: exclude the blocks that are not supported in the 'turn into' types - [`581fb2c`](https://github.com/AppFlowy-IO/AppFlowy/commit/581fb2c2f0e77469fe4bf737a6a712ef6f110b0d) fix: add logs - [`8b8fff9`](https://github.com/AppFlowy-IO/AppFlowy/commit/8b8fff9f11f2d3d72cac32fcfc893e6b2f06be9a) fix: floating toolbar ai status - [`ca3f225`](https://github.com/AppFlowy-IO/AppFlowy/commit/ca3f22559b95748dc2bf901ffc0859dc93cc0d2a) test: selecting the parent should deselect all the child nodes as well - [`8ca7c56`](https://github.com/AppFlowy-IO/AppFlowy/commit/8ca7c56da895350582bf579ae62db6d5fc7c2c87) chore: 'Copy Link' to 'Copy link' - [`c417a94`](https://github.com/AppFlowy-IO/AppFlowy/commit/c417a94254bb69da873ee5356bd107e8002c7baf) fix: select all and turn into block doesn't work on Windows - [`b4872a4`](https://github.com/AppFlowy-IO/AppFlowy/commit/b4872a48bbd3fa6778baa4787040997ad5e1ca9f) test: calculate turn into selection test - [`98305ff`](https://github.com/AppFlowy-IO/AppFlowy/commit/98305ff6cc0c10f7e1ff5140d845784465091476) fix: option button tests ### 📊 Changes **12 files changed** (+661 additions, -294 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_option_action_test.dart` (+33 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_1.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart` (+35 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/draggable_option_button.dart` (+5 -262) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/draggable_option_button_feedback.dart` (+266 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/option_button.dart` (+138 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/base/cover_title_command.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_page_block.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/openai/widgets/smart_edit_toolbar_item.dart` (+17 -17) 📝 `frontend/appflowy_flutter/pubspec.lock` (+6 -6) 📝 `frontend/appflowy_flutter/test/unit_test/document/turn_into/turn_into_test.dart` (+150 -0) 📝 `frontend/resources/translations/en.json` (+3 -3) </details> ### 📄 Description   ### Feature Preview - [x] selecting the parent should deselect all the child nodes as well. - [x] test: selecting the parent should deselect all the child nodes as well. - [x] the inline mention style doesn’t support on mobile. - [x] test: the inline mention style doesn’t support on mobile.  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>