[PR #6577] [MERGED] fix(flutter-desktop): launch review issues for 0.7.2 #7467

New issue

Closed

opened 2026-03-23 23:19:45 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6577
Author: @richardshiue
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/18/2024
Merged by: @richardshiue

Base: main ← Head: fix/launch-review-072

📝 Commits (10+)

d44d64f test: add test case for calendar filter
d2cb6b8 fix: select option filter logic
f419bfb fix: calendar filters not applying if switched repeatedly
6d663f3 fix: checklist cell editor improvements
28f0831 fix: nested scrolling in checklist
8d2ef45 fix: make filter logic match notion
ca727fd test: fix checklist cell test
9b0bf03 test: single select filter tests
b80ce41 test: fix flutter test
9dbff7d test: fix rust tests

📊 Changes

20 files changed (+106 additions, -261 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_calendar_test.dart (+15 -2)
📝 frontend/appflowy_flutter/integration_test/desktop/database/database_filter_test.dart (+1 -1)
📝 frontend/appflowy_flutter/integration_test/shared/database_test_op.dart (+8 -7)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_filter_bottom_sheet.dart (+5 -21)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_filter_condition_list.dart (+0 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/application/field/filter_entities.dart (+2 -16)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/application/calendar_bloc.dart (+4 -14)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_page.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/select_option_loader.dart (+0 -45)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/condition_list.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart (+4 -14)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/select_option.dart (+2 -8)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart (+6 -6)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_entities_test.dart (+5 -26)
📝 frontend/rust-lib/flowy-database2/src/entities/filter_entities/select_option_filter.rs (+20 -2)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_filter.rs (+14 -32)
📝 frontend/rust-lib/flowy-database2/src/services/filter/entities.rs (+5 -2)
📝 frontend/rust-lib/flowy-database2/tests/database/filter_test/select_option_filter_test.rs (+0 -46)
📝 frontend/rust-lib/flowy-database2/tests/database/pre_fill_cell_test/pre_fill_row_according_to_filter_test.rs (+10 -12)

📄 Description

tests

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6577 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/18/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/launch-review-072` --- ### 📝 Commits (10+) - [`d44d64f`](https://github.com/AppFlowy-IO/AppFlowy/commit/d44d64f2de3ad4abfaedfe60fad64f4d61832fee) test: add test case for calendar filter - [`d2cb6b8`](https://github.com/AppFlowy-IO/AppFlowy/commit/d2cb6b8cedb1a33c87ddeb11e842f2627b404301) fix: select option filter logic - [`f419bfb`](https://github.com/AppFlowy-IO/AppFlowy/commit/f419bfb87e958808bc66238487f7ae3286af7a23) fix: calendar filters not applying if switched repeatedly - [`6d663f3`](https://github.com/AppFlowy-IO/AppFlowy/commit/6d663f33503f9a717c173a1b398b8df4959dcc1b) fix: checklist cell editor improvements - [`28f0831`](https://github.com/AppFlowy-IO/AppFlowy/commit/28f0831844df8a4dac35df06cb5de9f8466923c8) fix: nested scrolling in checklist - [`8d2ef45`](https://github.com/AppFlowy-IO/AppFlowy/commit/8d2ef45e7c49bd491356785f1332efb77ea07fc1) fix: make filter logic match notion - [`ca727fd`](https://github.com/AppFlowy-IO/AppFlowy/commit/ca727fdb28c02bd8de58cdb6a22df0733d36f9a0) test: fix checklist cell test - [`9b0bf03`](https://github.com/AppFlowy-IO/AppFlowy/commit/9b0bf03c60ef163d5409d1d8f49ef662a48b8fd1) test: single select filter tests - [`b80ce41`](https://github.com/AppFlowy-IO/AppFlowy/commit/b80ce4153c90d49eb8a458be43423d9be4339c90) test: fix flutter test - [`9dbff7d`](https://github.com/AppFlowy-IO/AppFlowy/commit/9dbff7d32f64c7d14d0f8d1a81f30532f8cf683b) test: fix rust tests ### 📊 Changes **20 files changed** (+106 additions, -261 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_calendar_test.dart` (+15 -2) 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_filter_test.dart` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/shared/database_test_op.dart` (+8 -7) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_filter_bottom_sheet.dart` (+5 -21) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/view/database_filter_condition_list.dart` (+0 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/field/filter_entities.dart` (+2 -16) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/application/calendar_bloc.dart` (+4 -14) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_page.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/select_option_loader.dart` (+0 -45) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/condition_list.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/option_list.dart` (+4 -14) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/select_option/select_option.dart` (+2 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart` (+6 -6) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_entities_test.dart` (+5 -26) 📝 `frontend/rust-lib/flowy-database2/src/entities/filter_entities/select_option_filter.rs` (+20 -2) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/selection_type_option/select_filter.rs` (+14 -32) 📝 `frontend/rust-lib/flowy-database2/src/services/filter/entities.rs` (+5 -2) 📝 `frontend/rust-lib/flowy-database2/tests/database/filter_test/select_option_filter_test.rs` (+0 -46) 📝 `frontend/rust-lib/flowy-database2/tests/database/pre_fill_cell_test/pre_fill_row_according_to_filter_test.rs` (+10 -12) </details> ### 📄 Description - [x] tests ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>