[PR #6595] [MERGED] fix: enable sub page block #7482

New issue

Closed

opened 2026-03-23 23:19:49 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6595
Author: @Xazin
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @Xazin

Base: main ← Head: fix/enable-sub-page-block

📝 Commits (10+)

b38e18d fix: enable sub page block
64fe6c1 fix: open newly inserted page
b8625a0 fix: created view should have empty name
cd723f9 test: use secondary to rename page
c5707af fix: make popover secondary interaction better
7ceb6ff Merge branch 'main' into fix/enable-sub-page-block
2bd24fe test: amend test
7710b23 fix: icon color of sub page block
810307e chore: merge branch 'upstream/main' into fix/enable-sub-page-block
85d0b26 test: fix tests

📊 Changes

15 files changed (+274 additions, -234 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart (+33 -38)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart (+2 -2)
📝 frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_view_item_test.dart (+7 -2)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+7 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_block_component.dart (+6 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_transaction_handler.dart (+6 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+23 -13)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart (+6 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/pop_up_action.dart (+17 -5)
📝 frontend/appflowy_flutter/packages/appflowy_popover/lib/src/layout.dart (+124 -140)
📝 frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart (+25 -9)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/src/flowy_overlay/appflowy_popover.dart (+9 -1)
📝 frontend/appflowy_flutter/pubspec.lock (+6 -6)

📄 Description

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6595 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/enable-sub-page-block` --- ### 📝 Commits (10+) - [`b38e18d`](https://github.com/AppFlowy-IO/AppFlowy/commit/b38e18d0edc2ff4970ccbe378b972abc0a93f71c) fix: enable sub page block - [`64fe6c1`](https://github.com/AppFlowy-IO/AppFlowy/commit/64fe6c1e8425a73d5b9c6fca7cbfe9c838d18612) fix: open newly inserted page - [`b8625a0`](https://github.com/AppFlowy-IO/AppFlowy/commit/b8625a0b7a52c706f8b01b1af3c3a7a5e2f8377a) fix: created view should have empty name - [`cd723f9`](https://github.com/AppFlowy-IO/AppFlowy/commit/cd723f9b518588fdcb3429dc26334c887c51f661) test: use secondary to rename page - [`c5707af`](https://github.com/AppFlowy-IO/AppFlowy/commit/c5707af6cf3c8b92851657797a911c0c2573cb09) fix: make popover secondary interaction better - [`7ceb6ff`](https://github.com/AppFlowy-IO/AppFlowy/commit/7ceb6ff1897ec6504a1e49e40aeb982d8069116b) Merge branch 'main' into fix/enable-sub-page-block - [`2bd24fe`](https://github.com/AppFlowy-IO/AppFlowy/commit/2bd24fe85fcd75359620467abe6c79792a148968) test: amend test - [`7710b23`](https://github.com/AppFlowy-IO/AppFlowy/commit/7710b234e5ac06fb5dc1b587197d07ce13c65901) fix: icon color of sub page block - [`810307e`](https://github.com/AppFlowy-IO/AppFlowy/commit/810307e70c760914ac6b654655fda9ad99480173) chore: merge branch 'upstream/main' into fix/enable-sub-page-block - [`85d0b26`](https://github.com/AppFlowy-IO/AppFlowy/commit/85d0b263bea4de2aa1febee49d7869b2e2bd0518) test: fix tests ### 📊 Changes **15 files changed** (+274 additions, -234 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart` (+33 -38) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart` (+2 -2) 📝 `frontend/appflowy_flutter/integration_test/desktop/sidebar/sidebar_view_item_test.dart` (+7 -2) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+7 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_block_component.dart` (+6 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_transaction_handler.dart` (+6 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+23 -13) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_more_action_button.dart` (+6 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/pop_up_action.dart` (+17 -5) 📝 `frontend/appflowy_flutter/packages/appflowy_popover/lib/src/layout.dart` (+124 -140) 📝 `frontend/appflowy_flutter/packages/appflowy_popover/lib/src/popover.dart` (+25 -9) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/src/flowy_overlay/appflowy_popover.dart` (+9 -1) 📝 `frontend/appflowy_flutter/pubspec.lock` (+6 -6) </details> ### 📄 Description   ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>