[PR #6619] [MERGED] fix: date picker code improvements and regressions #7493

New issue

Closed

opened 2026-03-23 23:19:52 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6619
Author: @richardshiue
Created: 10/24/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @richardshiue

Base: main ← Head: fix/date-picker-regressions-and-refactor

📝 Commits (3)

2984d1d chore: improve handling result's error variant
481b2e7 chore: dont call setState in didUpdateWidget
645dbc7 fix: don't make assumptions on provided data

📊 Changes

7 files changed (+79 additions, -44 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_editor_bloc.dart (+4 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker.dart (+12 -14)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/mobile_appflowy_date_picker.dart (+12 -14)
📝 frontend/appflowy_flutter/pubspec.lock (+6 -6)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/cell/date_cell_bloc_test.dart (+36 -1)
📝 frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs (+6 -2)

📄 Description

follow up to #6582

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6619 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/date-picker-regressions-and-refactor` --- ### 📝 Commits (3) - [`2984d1d`](https://github.com/AppFlowy-IO/AppFlowy/commit/2984d1d3af538594fe65f872a34ffd863e573f71) chore: improve handling result's error variant - [`481b2e7`](https://github.com/AppFlowy-IO/AppFlowy/commit/481b2e7747d009068264ab303bd0af7f40327356) chore: dont call setState in didUpdateWidget - [`645dbc7`](https://github.com/AppFlowy-IO/AppFlowy/commit/645dbc78f44c6891b741a7d36e74abf9adb01fec) fix: don't make assumptions on provided data ### 📊 Changes **7 files changed** (+79 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_editor_bloc.dart` (+4 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker.dart` (+12 -14) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/mobile_appflowy_date_picker.dart` (+12 -14) 📝 `frontend/appflowy_flutter/pubspec.lock` (+6 -6) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/cell/date_cell_bloc_test.dart` (+36 -1) 📝 `frontend/rust-lib/flowy-database2/src/services/field/type_options/date_type_option/date_type_option.rs` (+6 -2) </details> ### 📄 Description follow up to #6582 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>