[PR #6620] [MERGED] feat: add same delete design in database #7494

New issue

Closed

opened 2026-03-23 23:19:53 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6620
Author: @Ahad-patel
Created: 10/24/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @LucasXu0

Base: main ← Head: fix-delete-button-design

📝 Commits (3)

cac2bec add same delete design in database
57c0e49 fix: remove padding when widget is null or function is null
86b139c Merge branch 'main' into fix-delete-button-design

📊 Changes

2 files changed (+28 additions, -15 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart (+17 -9)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/button.dart (+11 -6)

📄 Description

closes : #6608

Feature Preview

I have updated FlowyButton with FlowyIconTextButton. I have also added resetHoverOnRebuild in FlowyIconTextButton. Since leftIconBuilder and rightIconBuilder require non-nullable widget, I have updated action.leading and action.trailing to return Sizedbox.shrink() instead of null and made return type Widget in pace of Widget?.

One question though, is any where else this delete design needed to be added? and does it require test cases? @richardshiue @annieappflowy

https://github.com/user-attachments/assets/05e74709-52a3-4fce-be49-774a56bd5699

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6620 **Author:** [@Ahad-patel](https://github.com/Ahad-patel) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix-delete-button-design` --- ### 📝 Commits (3) - [`cac2bec`](https://github.com/AppFlowy-IO/AppFlowy/commit/cac2bec73d18f3c1bbcca453a32e60c67c75d0bc) add same delete design in database - [`57c0e49`](https://github.com/AppFlowy-IO/AppFlowy/commit/57c0e499737d46d88d1ed103e76fa86f85dd505f) fix: remove padding when widget is null or function is null - [`86b139c`](https://github.com/AppFlowy-IO/AppFlowy/commit/86b139c6901963efae0f33962e72d73b01e25b83) Merge branch 'main' into fix-delete-button-design ### 📊 Changes **2 files changed** (+28 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/field/field_editor.dart` (+17 -9) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/button.dart` (+11 -6) </details> ### 📄 Description   closes : #6608 ### Feature Preview I have updated FlowyButton with FlowyIconTextButton. I have also added resetHoverOnRebuild in FlowyIconTextButton. Since leftIconBuilder and rightIconBuilder require non-nullable widget, I have updated action.leading and action.trailing to return Sizedbox.shrink() instead of null and made return type Widget in pace of Widget?. One question though, is any where else this delete design needed to be added? and does it require test cases? @richardshiue @annieappflowy  ---  https://github.com/user-attachments/assets/05e74709-52a3-4fce-be49-774a56bd5699 #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>