[PR #6669] [MERGED] fix(flutter_desktop): document search #7515

New issue

Closed

opened 2026-03-23 23:19:59 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:19:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6669
Author: @richardshiue
Created: 10/30/2024
Status: ✅ Merged
Merged: 11/14/2024
Merged by: @richardshiue

Base: main ← Head: fix/find-menu

📝 Commits (10+)

e7fcb30 fix: double dispose on find menu
ec25648 fix: empty query not resetting search service
9e9e1c5 fix: input focus getting lost after clicking button or pressing enter
b2af482 chore: remove unused focus node and text controller
8ad6977 chore: bump appflowy editor
5ab16dd chore: code cleanup
2b04be4 chore: fix focus getting lost on submission
336a882 fix: next match focuses on title after jumping
43b14cb chore: bump appflowy editor
4d065cc revert: unnecessary changes to FlowyFormTextInput

📊 Changes

9 files changed (+315 additions, -154 deletions)

View changed files

➕ frontend/appflowy_flutter/integration_test/desktop/document/document_find_menu_test.dart (+144 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_4.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+10 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/find_and_replace/find_and_replace_menu.dart (+124 -108)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart (+25 -32)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart (+0 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shared_context/shared_context.dart (+8 -3)
📝 frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_input.dart (+1 -2)

📄 Description

resolves https://github.com/AppFlowy-IO/AppFlowy/issues/6480

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6669 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 11/14/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/find-menu` --- ### 📝 Commits (10+) - [`e7fcb30`](https://github.com/AppFlowy-IO/AppFlowy/commit/e7fcb30feb39639ed85d11332b703cb1c6479c97) fix: double dispose on find menu - [`ec25648`](https://github.com/AppFlowy-IO/AppFlowy/commit/ec256480d9c0f46c74ee12a73394b8f52385e555) fix: empty query not resetting search service - [`9e9e1c5`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e9e1c53509b7d367fbd09b2c34c3a61e195e21a) fix: input focus getting lost after clicking button or pressing enter - [`b2af482`](https://github.com/AppFlowy-IO/AppFlowy/commit/b2af48297dadc18bded836754cc559ff45950f36) chore: remove unused focus node and text controller - [`8ad6977`](https://github.com/AppFlowy-IO/AppFlowy/commit/8ad69771ccfd70da5a0d952331ebba96825f335e) chore: bump appflowy editor - [`5ab16dd`](https://github.com/AppFlowy-IO/AppFlowy/commit/5ab16dd16256097e794b0407c626b995cb90b00b) chore: code cleanup - [`2b04be4`](https://github.com/AppFlowy-IO/AppFlowy/commit/2b04be43ca762130d0d89c79eb558dda5e584464) chore: fix focus getting lost on submission - [`336a882`](https://github.com/AppFlowy-IO/AppFlowy/commit/336a882750b660999c9d27f8c2ce017487bc66eb) fix: next match focuses on title after jumping - [`43b14cb`](https://github.com/AppFlowy-IO/AppFlowy/commit/43b14cbc2043c6e95d43939e3f3d4569b4480fef) chore: bump appflowy editor - [`4d065cc`](https://github.com/AppFlowy-IO/AppFlowy/commit/4d065cc30d9b5aede079b4e0991c30b3c74ef4fb) revert: unnecessary changes to FlowyFormTextInput ### 📊 Changes **9 files changed** (+315 additions, -154 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/desktop/document/document_find_menu_test.dart` (+144 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_4.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+10 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/find_and_replace/find_and_replace_menu.dart` (+124 -108) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart` (+25 -32) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/document_cover_widget.dart` (+0 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shared_context/shared_context.dart` (+8 -3) 📝 `frontend/appflowy_flutter/packages/flowy_infra_ui/lib/style_widget/text_input.dart` (+1 -2) </details> ### 📄 Description resolves https://github.com/AppFlowy-IO/AppFlowy/issues/6480 ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>