[PR #6672] [MERGED] fix: owner can delete spaces created by other users #7516

Closed
opened 2026-03-23 23:19:59 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6672
Author: @Ahad-patel
Created: 10/30/2024
Status: Merged
Merged: 11/1/2024
Merged by: @LucasXu0

Base: mainHead: owner-can-delete-spaces


📝 Commits (3)

  • 44518df fix: owner can delete spaces created by other users
  • 97e4b9f fix: Update frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_more_popup.dart
  • e77b641 fix: add import statement and remove conficting code

📊 Changes

1 file changed (+14 additions, -1 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_more_popup.dart (+14 -1)

📄 Description

closes: #6444

Feature Preview

I added condition which check if the current user is owner of the workspace then, the owner is eligible to delete spaces created by any of the members, but members only have permission to delete the spaces created by them.


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6672 **Author:** [@Ahad-patel](https://github.com/Ahad-patel) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `owner-can-delete-spaces` --- ### 📝 Commits (3) - [`44518df`](https://github.com/AppFlowy-IO/AppFlowy/commit/44518df31deb9e04fd37a506bdadfe9076f522fb) fix: owner can delete spaces created by other users - [`97e4b9f`](https://github.com/AppFlowy-IO/AppFlowy/commit/97e4b9f7c10a1d751786c81dca9352570a0ad738) fix: Update frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_more_popup.dart - [`e77b641`](https://github.com/AppFlowy-IO/AppFlowy/commit/e77b641c260c3896ea330dc1afdd94683ec891e3) fix: add import statement and remove conficting code ### 📊 Changes **1 file changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/space_more_popup.dart` (+14 -1) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> closes: #6444 ### Feature Preview I added condition which check if the current user is owner of the workspace then, the owner is eligible to delete spaces created by any of the members, but members only have permission to delete the spaces created by them. <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:19:59 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7516
No description provided.