[PR #6675] [MERGED] feat(flutter_desktop): press enter to confirm a dialog #7521

New issue

Closed

opened 2026-03-23 23:20:00 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6675
Author: @richardshiue
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @richardshiue

Base: main ← Head: feat/enter-dialog

📝 Commits (2)

a5c7772 feat: enter to confirm in popup dialog
24e5587 test: add test

📊 Changes

4 files changed (+172 additions, -71 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/shared_widget.dart (+6 -0)
➕ frontend/appflowy_flutter/test/widget_test/confirm_dialog_test.dart (+91 -0)
📝 frontend/appflowy_flutter/test/widget_test/date_picker_test.dart (+1 -71)
➕ frontend/appflowy_flutter/test/widget_test/test_material_app.dart (+74 -0)

📄 Description

only supports the primary action for now, does not support keyboard navigation with arrow keys and tab

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6675 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `feat/enter-dialog` --- ### 📝 Commits (2) - [`a5c7772`](https://github.com/AppFlowy-IO/AppFlowy/commit/a5c77720945dc603fb5b7d2478bc8e932b2d444d) feat: enter to confirm in popup dialog - [`24e5587`](https://github.com/AppFlowy-IO/AppFlowy/commit/24e55873b35859b3df04371636452d2f6f7330a5) test: add test ### 📊 Changes **4 files changed** (+172 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/space/shared_widget.dart` (+6 -0) ➕ `frontend/appflowy_flutter/test/widget_test/confirm_dialog_test.dart` (+91 -0) 📝 `frontend/appflowy_flutter/test/widget_test/date_picker_test.dart` (+1 -71) ➕ `frontend/appflowy_flutter/test/widget_test/test_material_app.dart` (+74 -0) </details> ### 📄 Description only supports the primary action for now, does not support keyboard navigation with arrow keys and tab ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>