[PR #6680] [MERGED] fix: reminder bugs/changes #7523

New issue

Closed

opened 2026-03-23 23:20:00 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6680
Author: @Xazin
Created: 10/31/2024
Status: ✅ Merged
Merged: 10/31/2024
Merged by: @Xazin

Base: main ← Head: fix/reminder-changes

📝 Commits (1)

9f276f2 fix: reminder improvements

📊 Changes

9 files changed (+55 additions, -81 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/mobile/presentation/notifications/mobile_notifications_page.dart (+5 -9)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart (+3 -12)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart (+1 -0)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/mention_transaction_handler.dart (+23 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart (+0 -6)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/notification_dialog.dart (+22 -27)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_item.dart (+0 -23)
📝 frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_view.dart (+0 -3)

📄 Description

Removes "Delete" option from a notification item
Fixes a bug where showing same reminders in both inbox and upcoming
Fixes a bug where not correctly displaying whether there are unread reminders

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6680 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 10/31/2024 **Status:** ✅ Merged **Merged:** 10/31/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/reminder-changes` --- ### 📝 Commits (1) - [`9f276f2`](https://github.com/AppFlowy-IO/AppFlowy/commit/9f276f2c9786041607281dfd9f3f0f42290d4530) fix: reminder improvements ### 📊 Changes **9 files changed** (+55 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/mobile/presentation/notifications/mobile_notifications_page.dart` (+5 -9) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart` (+3 -12) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart` (+1 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/mention_transaction_handler.dart` (+23 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart` (+0 -6) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/notification_dialog.dart` (+22 -27) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_button.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_item.dart` (+0 -23) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/notifications/widgets/notification_view.dart` (+0 -3) </details> ### 📄 Description - [x] Removes "Delete" option from a notification item - [x] Fixes a bug where showing same reminders in both inbox and upcoming - [x] Fixes a bug where not correctly displaying whether there are unread reminders #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>