[PR #6693] [MERGED] fix: do not rely on getIt in turnIntoBlock #7529

New issue

Closed

opened 2026-03-23 23:20:02 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:02 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6693
Author: @Xazin
Created: 11/1/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @Xazin

Base: main ← Head: fix/tests

📝 Commits (1)

e1e5469 fix: do not rely on getIt in turnIntoBlock

📊 Changes

3 files changed (+15 additions, -9 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart (+10 -7)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart (+3 -0)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)

📄 Description

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6693 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 11/1/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/tests` --- ### 📝 Commits (1) - [`e1e5469`](https://github.com/AppFlowy-IO/AppFlowy/commit/e1e5469949e9ec5e7e6056b1452ffbd66e9920f8) fix: do not rely on getIt in turnIntoBlock ### 📊 Changes **3 files changed** (+15 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart` (+10 -7) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart` (+3 -0) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) </details> ### 📄 Description #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [ ] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>