[PR #6698] [MERGED] chore: launch review 0.7.3 #7534

Closed
opened 2026-03-23 23:20:03 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6698
Author: @richardshiue
Created: 11/1/2024
Status: Merged
Merged: 11/4/2024
Merged by: @appflowy

Base: mainHead: chore/date-picker-ux


📝 Commits (10+)

  • 412108c refactor: date picker
  • e3bb7ca chore: provide guidance to users while using date picker
  • d1542b7 fix: row card icon alignment
  • 268f611 fix: untitled database views
  • 3a46c38 chore: hide hint text while choosing date range
  • 759cfcc test: fix widget test
  • ac40479 chore: use current time when toggling include time
  • 49affd4 chore: move autofill date logic to date picker
  • 962bca6 test: add tests
  • 26da9a5 chore: also apply to mention date block

📊 Changes

21 files changed (+849 additions, -631 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_cell_test.dart (+6 -7)
📝 frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart (+5 -7)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_date_reminder_test.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/mobile/presentation/database/date_picker/mobile_date_picker_screen.dart (+13 -5)
📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_editor_bloc.dart (+25 -15)
📝 frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_day.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/date.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart (+5 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart (+20 -7)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_style_maps/desktop_board_card_cell_style.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_text_cell.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/date_cell_editor.dart (+14 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart (+12 -4)
frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker_base.dart (+335 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/desktop_date_picker.dart (+31 -190)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/mobile_date_picker.dart (+76 -300)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_picker_dialog.dart (+7 -8)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_time_text_field.dart (+35 -26)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/cell/date_cell_bloc_test.dart (+64 -20)

...and 1 more files

📄 Description

  • date picker refactor
  • automatically select current time
  • add hint text
  • row card icon alignment issue
  • untitled database view issue
  • calendar new event radius
  • tests

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6698 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/1/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@appflowy](https://github.com/appflowy) **Base:** `main` ← **Head:** `chore/date-picker-ux` --- ### 📝 Commits (10+) - [`412108c`](https://github.com/AppFlowy-IO/AppFlowy/commit/412108caeb0003e6f076bf59a3d893c742745ff8) refactor: date picker - [`e3bb7ca`](https://github.com/AppFlowy-IO/AppFlowy/commit/e3bb7cada4fcb3701836123fd95758f8df50c674) chore: provide guidance to users while using date picker - [`d1542b7`](https://github.com/AppFlowy-IO/AppFlowy/commit/d1542b7cf1d89ae1751a7517ecfa0edee329c282) fix: row card icon alignment - [`268f611`](https://github.com/AppFlowy-IO/AppFlowy/commit/268f611f35b300c660c4f9454e005fc421f7fe35) fix: untitled database views - [`3a46c38`](https://github.com/AppFlowy-IO/AppFlowy/commit/3a46c3836b189361beaecdb472dc471c0d54df87) chore: hide hint text while choosing date range - [`759cfcc`](https://github.com/AppFlowy-IO/AppFlowy/commit/759cfcccf65dd91198c47e94b8d80a450b1d4dce) test: fix widget test - [`ac40479`](https://github.com/AppFlowy-IO/AppFlowy/commit/ac40479fe0086adf0ce175c69fe534780848025d) chore: use current time when toggling include time - [`49affd4`](https://github.com/AppFlowy-IO/AppFlowy/commit/49affd44434e90ec6b525deaf4f15830e3f707ae) chore: move autofill date logic to date picker - [`962bca6`](https://github.com/AppFlowy-IO/AppFlowy/commit/962bca6bd5f11470783c8b008baf0f99a9681613) test: add tests - [`26da9a5`](https://github.com/AppFlowy-IO/AppFlowy/commit/26da9a54aa04d7fb3acae5dd3a689f601b1ee57e) chore: also apply to mention date block ### 📊 Changes **21 files changed** (+849 additions, -631 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_cell_test.dart` (+6 -7) 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_field_test.dart` (+5 -7) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_date_reminder_test.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/database/date_picker/mobile_date_picker_screen.dart` (+13 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_editor_bloc.dart` (+25 -15) 📝 `frontend/appflowy_flutter/lib/plugins/database/calendar/presentation/calendar_day.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/grid/presentation/widgets/filter/choicechip/date.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart` (+5 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_skeleton/text_card_cell.dart` (+20 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/card_cell_style_maps/desktop_board_card_cell_style.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_text_cell.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/date_cell_editor.dart` (+14 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_date_block.dart` (+12 -4) ➕ `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker_base.dart` (+335 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/desktop_date_picker.dart` (+31 -190) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/mobile_date_picker.dart` (+76 -300) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_picker_dialog.dart` (+7 -8) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/date_time_text_field.dart` (+35 -26) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/cell/date_cell_bloc_test.dart` (+64 -20) _...and 1 more files_ </details> ### 📄 Description - date picker refactor - automatically select current time - add hint text - row card icon alignment issue - untitled database view issue - calendar new event radius - tests ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:03 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7534
No description provided.