[PR #6714] [MERGED] fix: toggle heading issues #7541

New issue

Closed

opened 2026-03-23 23:20:05 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6714
Author: @LucasXu0
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @LucasXu0

Base: main ← Head: fix_toggle_heading_issues

📝 Commits (8)

156882a fix: pages overflow when selecting homepage
7b93dcc fix: toggle heading issues
33bd09c Revert "fix: pages overflow when selecting homepage"
d6bd6ea chore: optimize code logic
9a03c7c fix: assertion in toggle list
596b2fc fix: make the turn into menu and color menu exclusive
5e8e98c test: add toggle heading test
009eb35 Merge branch 'main' into fix_toggle_heading_issues

📊 Changes

13 files changed (+298 additions, -82 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_toggle_heading_block_test.dart (+46 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart (+12 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_button.dart (+40 -17)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart (+8 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/color_option_action.dart (+50 -13)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart (+54 -15)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/heading/heading_toolbar_item.dart (+38 -11)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shortcuts/heading_block_shortcuts.dart (+2 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart (+44 -16)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)
📝 frontend/resources/translations/en.json (+1 -1)

📄 Description

Feature Preview

keep toggle heading's children when converting to heading block (need adding test)
update translation, Spaces -> spaces (no test required)
only rotate the expand icon when toggling the list (no test required)
highlight the children blocks after toggling (no test required)
exlucde the padding when selecting heading block or toggle heading block (no test required)

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6714 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_toggle_heading_issues` --- ### 📝 Commits (8) - [`156882a`](https://github.com/AppFlowy-IO/AppFlowy/commit/156882a9a7e039a38cd206306e19b94eb391f948) fix: pages overflow when selecting homepage - [`7b93dcc`](https://github.com/AppFlowy-IO/AppFlowy/commit/7b93dcc2c6033f7ed481f35ca9cd7563884b25ac) fix: toggle heading issues - [`33bd09c`](https://github.com/AppFlowy-IO/AppFlowy/commit/33bd09c6cda0bf8b0a06494cfa3b06aeeb88b33e) Revert "fix: pages overflow when selecting homepage" - [`d6bd6ea`](https://github.com/AppFlowy-IO/AppFlowy/commit/d6bd6ea69f8570415ff817ea43c705d65ffc18cb) chore: optimize code logic - [`9a03c7c`](https://github.com/AppFlowy-IO/AppFlowy/commit/9a03c7c9fe616df247fcd5f3d41d898ca140cb65) fix: assertion in toggle list - [`596b2fc`](https://github.com/AppFlowy-IO/AppFlowy/commit/596b2fc74b0e08a4cdfcdbb88843a543f6112f3c) fix: make the turn into menu and color menu exclusive - [`5e8e98c`](https://github.com/AppFlowy-IO/AppFlowy/commit/5e8e98ce53f3f885b00c7288c39ef6061cc90915) test: add toggle heading test - [`009eb35`](https://github.com/AppFlowy-IO/AppFlowy/commit/009eb35873fdb5c44afc1e89f9a786b00539d78c) Merge branch 'main' into fix_toggle_heading_issues ### 📊 Changes **13 files changed** (+298 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_toggle_heading_block_test.dart` (+46 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart` (+12 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_button.dart` (+40 -17) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_cubit.dart` (+8 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/color_option_action.dart` (+50 -13) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart` (+54 -15) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/heading/heading_toolbar_item.dart` (+38 -11) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shortcuts/heading_block_shortcuts.dart` (+2 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart` (+44 -16) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) 📝 `frontend/resources/translations/en.json` (+1 -1) </details> ### 📄 Description   ### Feature Preview - [x] keep toggle heading's children when converting to heading block (need adding test) - [x] update translation, Spaces -> spaces (no test required) - [x] only rotate the expand icon when toggling the list (no test required) - [x] highlight the children blocks after toggling (no test required) - [x] exlucde the padding when selecting heading block or toggle heading block (no test required)  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>