[PR #6726] [MERGED] fix: align the namespace and toggle shortcuts #7547

Closed
opened 2026-03-23 23:20:07 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6726
Author: @LucasXu0
Created: 11/5/2024
Status: Merged
Merged: 11/6/2024
Merged by: @LucasXu0

Base: mainHead: namespace_align


📝 Commits (4)

  • fd9c529 chore: update translations, url to URL
  • a002369 fix: children disapper when using toggle shortcuts
  • 66682ab fix: add tooltip for namespace button
  • 2817273 test: add toggle shortcut test

📊 Changes

6 files changed (+65 additions, -25 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcuts.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/sites/domain/domain_item.dart (+24 -20)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)
📝 frontend/appflowy_flutter/test/unit_test/document/shortcuts/toggle_list_shortcut_test.dart (+35 -0)
📝 frontend/resources/translations/en.json (+2 -2)

📄 Description

Feature Preview

  • align the namespace with header (no test required)
  • toggle shortcuts (need adding test)
  • update translations and add a tooltip (no test required)

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6726 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/6/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `namespace_align` --- ### 📝 Commits (4) - [`fd9c529`](https://github.com/AppFlowy-IO/AppFlowy/commit/fd9c529d39b5494644be3706097a390c015c0b16) chore: update translations, url to URL - [`a002369`](https://github.com/AppFlowy-IO/AppFlowy/commit/a002369d6666590d81c35795a0c2dcdcd096b8b8) fix: children disapper when using toggle shortcuts - [`66682ab`](https://github.com/AppFlowy-IO/AppFlowy/commit/66682abeedf992c13a2d769e592453f2b1ddf69d) fix: add tooltip for namespace button - [`2817273`](https://github.com/AppFlowy-IO/AppFlowy/commit/2817273bd216c089f7d6f99114171b8269d1f712) test: add toggle shortcut test ### 📊 Changes **6 files changed** (+65 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcuts.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/sites/domain/domain_item.dart` (+24 -20) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) 📝 `frontend/appflowy_flutter/test/unit_test/document/shortcuts/toggle_list_shortcut_test.dart` (+35 -0) 📝 `frontend/resources/translations/en.json` (+2 -2) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] align the namespace with header (no test required) - [x] toggle shortcuts (need adding test) - [x] update translations and add a tooltip (no test required) <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:07 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7547
No description provided.