[PR #6730] [MERGED] fix: v0.7.3 additional launch review session issues #7548

New issue

Closed

opened 2026-03-23 23:20:07 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6730
Author: @richardshiue
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @richardshiue

Base: main ← Head: fix/0.7.3.2-launch-review

📝 Commits (10+)

c37fd67 fix: focusedDay on is range toggle
147042f fix: attempt to fix date reminder
7824665 chore: alignment issue on windows
3213bb5 chore: use onFailure
a1d3773 chore: default for set reminder
b9b8ae6 chore: code style
5128d5f fix: add reminder bug
18cf7af fix: checklist item alignment
c804289 fix: date cell reminders
a2fede3 chore: regard cell datetime as correct

📊 Changes

15 files changed (+441 additions, -244 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_editor_bloc.dart (+129 -105)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart (+76 -52)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_textfield.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker_base.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/desktop_date_picker.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/reminder_selector.dart (+11 -6)
📝 frontend/appflowy_flutter/test/bloc_test/grid_test/cell/date_cell_bloc_test.dart (+138 -0)
📝 frontend/appflowy_tauri/src-tauri/Cargo.lock (+20 -20)
📝 frontend/appflowy_tauri/src-tauri/Cargo.toml (+8 -8)
📝 frontend/appflowy_web_app/src-tauri/Cargo.lock (+20 -20)
📝 frontend/appflowy_web_app/src-tauri/Cargo.toml (+8 -8)
📝 frontend/rust-lib/Cargo.lock (+8 -8)
📝 frontend/rust-lib/Cargo.toml (+8 -8)
📝 frontend/rust-lib/flowy-user/src/user_manager/manager_user_awareness.rs (+10 -2)

📄 Description

requires https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/336

When toggling end date aka is range option, the focused day of the calendar doesn't immediately change to the selected date. (no tests)
Checklist item alignment issue due to visual density changes (no tests)
Fix reminders not working at all (tests added)
Fix reminder not being able to be updated twice (tests added), see collab PR and date_cell_bloc_test.dart

https://github.com/user-attachments/assets/ec5e88f3-c083-4a0d-9e2a-21af31a8d1b4
fix a small ui mishap where the date time text field gets updated too quickly

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6730 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/0.7.3.2-launch-review` --- ### 📝 Commits (10+) - [`c37fd67`](https://github.com/AppFlowy-IO/AppFlowy/commit/c37fd67578a2ba795ad8e773f17abf4dd14f1b72) fix: focusedDay on is range toggle - [`147042f`](https://github.com/AppFlowy-IO/AppFlowy/commit/147042f1f448d6b240d9bd0fb85239787ad29e66) fix: attempt to fix date reminder - [`7824665`](https://github.com/AppFlowy-IO/AppFlowy/commit/782466507ec16b76287bb30acc379f63295b6809) chore: alignment issue on windows - [`3213bb5`](https://github.com/AppFlowy-IO/AppFlowy/commit/3213bb5e0968053147c4d9cb4b734d0b536b355d) chore: use onFailure - [`a1d3773`](https://github.com/AppFlowy-IO/AppFlowy/commit/a1d377323a82584f9215f8dcd5ef25812031282d) chore: default for set reminder - [`b9b8ae6`](https://github.com/AppFlowy-IO/AppFlowy/commit/b9b8ae6b749211e91d37b0d7c482b53871c342c3) chore: code style - [`5128d5f`](https://github.com/AppFlowy-IO/AppFlowy/commit/5128d5f94696ba1a81b3a0d2de43c8bccae43b36) fix: add reminder bug - [`18cf7af`](https://github.com/AppFlowy-IO/AppFlowy/commit/18cf7affa0b9dc7b2751a944dd8a99b2995a0405) fix: checklist item alignment - [`c804289`](https://github.com/AppFlowy-IO/AppFlowy/commit/c8042897893cf2b9d69daf01dcadcc829fbc1ba4) fix: date cell reminders - [`a2fede3`](https://github.com/AppFlowy-IO/AppFlowy/commit/a2fede3dca5f3675a9d2d2d80b303e984ba11d76) chore: regard cell datetime as correct ### 📊 Changes **15 files changed** (+441 additions, -244 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/database/application/cell/bloc/date_cell_editor_bloc.dart` (+129 -105) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_checklist_cell.dart` (+76 -52) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_editor.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell_editor/checklist_cell_textfield.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/appflowy_date_picker_base.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/desktop_date_picker.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/date_picker/widgets/reminder_selector.dart` (+11 -6) 📝 `frontend/appflowy_flutter/test/bloc_test/grid_test/cell/date_cell_bloc_test.dart` (+138 -0) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.lock` (+20 -20) 📝 `frontend/appflowy_tauri/src-tauri/Cargo.toml` (+8 -8) 📝 `frontend/appflowy_web_app/src-tauri/Cargo.lock` (+20 -20) 📝 `frontend/appflowy_web_app/src-tauri/Cargo.toml` (+8 -8) 📝 `frontend/rust-lib/Cargo.lock` (+8 -8) 📝 `frontend/rust-lib/Cargo.toml` (+8 -8) 📝 `frontend/rust-lib/flowy-user/src/user_manager/manager_user_awareness.rs` (+10 -2) </details> ### 📄 Description requires https://github.com/AppFlowy-IO/AppFlowy-Collab/pull/336 - When toggling end date aka is range option, the focused day of the calendar doesn't immediately change to the selected date. (no tests) ![screenie](https://github.com/user-attachments/assets/7e2fd7a7-5272-429f-bb18-d8a25a0bf4c2) - Checklist item alignment issue due to visual density changes (no tests) ![image (1)](https://github.com/user-attachments/assets/cd416bf4-68c9-4a58-ac99-686426467233) - Fix reminders not working at all (tests added) - Fix reminder not being able to be updated twice (tests added), see collab PR and date_cell_bloc_test.dart https://github.com/user-attachments/assets/ec5e88f3-c083-4a0d-9e2a-21af31a8d1b4 - fix a small ui mishap where the date time text field gets updated too quickly ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>