[PR #6739] [MERGED] fix: block option interceptor #7556

Closed
opened 2026-03-23 23:20:11 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6739
Author: @Xazin
Created: 11/6/2024
Status: Merged
Merged: 11/7/2024
Merged by: @LucasXu0

Base: mainHead: fix/block-option-interceptor


📝 Commits (2)

  • d07ad3e fix: use unique key in interceptor
  • 167e034 test: add block option interaction tests

📊 Changes

3 files changed (+53 additions, -5 deletions)

View changed files

frontend/appflowy_flutter/integration_test/desktop/document/document_block_option_test.dart (+47 -0)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_4.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/option_button.dart (+4 -2)

📄 Description

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6739 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 11/6/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix/block-option-interceptor` --- ### 📝 Commits (2) - [`d07ad3e`](https://github.com/AppFlowy-IO/AppFlowy/commit/d07ad3e7a99d41490d7e32d887a2688f38b7634f) fix: use unique key in interceptor - [`167e034`](https://github.com/AppFlowy-IO/AppFlowy/commit/167e034488f4d19b2318750d5fead9df403b5e7b) test: add block option interaction tests ### 📊 Changes **3 files changed** (+53 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `frontend/appflowy_flutter/integration_test/desktop/document/document_block_option_test.dart` (+47 -0) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_4.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/option_button.dart` (+4 -2) </details> ### 📄 Description #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:11 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7556
No description provided.