[PR #6758] [MERGED] feat: optimize the workspace menu loading speed #7562

Closed
opened 2026-03-23 23:20:12 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6758
Author: @LucasXu0
Created: 11/11/2024
Status: Merged
Merged: 11/13/2024
Merged by: @LucasXu0

Base: mainHead: optimize_workspace_member_count


📝 Commits (6)

  • 92af1ee feat: optimize the workspace menu loading speed
  • c466632 chore: add workspace menu animation
  • 5c2cb0c feat: optimize workspace menu loading speed on mobile
  • 9e6de7e Merge branch 'main' into optimize_workspace_member_count
  • 712679c test: workspace member count test
  • 0321c71 fix: rust ci

📊 Changes

7 files changed (+87 additions, -61 deletions)

View changed files

📝 .github/workflows/rust_ci.yaml (+3 -2)
📝 frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/collaborative_workspace_test.dart (+28 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart (+46 -54)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart (+4 -1)
📝 frontend/rust-lib/flowy-user/src/user_manager/manager_user_workspace.rs (+2 -0)

📄 Description

Feature Preview

  • fetch the member count using the getAllWorkspaces API instead of fetching the member count individually to optimize the loading speed.
  • tests

before

https://github.com/user-attachments/assets/96e55982-64bc-4343-af14-d12fe2a3e6e0

after

https://github.com/user-attachments/assets/28238fbe-e26f-4d71-9481-22e0569e710d


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6758 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/11/2024 **Status:** ✅ Merged **Merged:** 11/13/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `optimize_workspace_member_count` --- ### 📝 Commits (6) - [`92af1ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/92af1ee5c0e108ba560923c29898225a621805c5) feat: optimize the workspace menu loading speed - [`c466632`](https://github.com/AppFlowy-IO/AppFlowy/commit/c466632979701ed453dea37b2b243a0aa80f7cda) chore: add workspace menu animation - [`5c2cb0c`](https://github.com/AppFlowy-IO/AppFlowy/commit/5c2cb0c150bde19849d98c6c8c40395035c37aac) feat: optimize workspace menu loading speed on mobile - [`9e6de7e`](https://github.com/AppFlowy-IO/AppFlowy/commit/9e6de7edfff74a04c4f8f83801d87f97c8c84caf) Merge branch 'main' into optimize_workspace_member_count - [`712679c`](https://github.com/AppFlowy-IO/AppFlowy/commit/712679cd8816a1b686fa4f5f18fbfcdcc8994948) test: workspace member count test - [`0321c71`](https://github.com/AppFlowy-IO/AppFlowy/commit/0321c71d06e6895378755db5ce4bbc166c4240a2) fix: rust ci ### 📊 Changes **7 files changed** (+87 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/rust_ci.yaml` (+3 -2) 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/workspace/collaborative_workspace_test.dart` (+28 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart` (+46 -54) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart` (+4 -1) 📝 `frontend/rust-lib/flowy-user/src/user_manager/manager_user_workspace.rs` (+2 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] fetch the member count using the getAllWorkspaces API instead of fetching the member count individually to optimize the loading speed. - [x] tests **before** https://github.com/user-attachments/assets/96e55982-64bc-4343-af14-d12fe2a3e6e0 **after** https://github.com/user-attachments/assets/28238fbe-e26f-4d71-9481-22e0569e710d <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:12 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7562
No description provided.