[PR #6784] [MERGED] feat: add toggle heading in plus menu on mobile #7574

Closed
opened 2026-03-23 23:20:15 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6784
Author: @LucasXu0
Created: 11/14/2024
Status: Merged
Merged: 11/14/2024
Merged by: @LucasXu0

Base: mainHead: add_toggle_heading_in_plus_menu


📝 Commits (7)

  • 6170a09 chore: add logs in space bloc
  • b372da6 feat: add toggle headings in plus menu
  • 96fe1ed test: add toggle heading block test
  • b51e962 test: toogle heading 1 block test
  • 8e4a9bf test: add toggle heading selection test
  • 2eb9eca fix: toggle headings test
  • adcdb70 chore: update new toggle heading icons

📊 Changes

12 files changed (+251 additions, -20 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/mobile/document/document_test_runner.dart (+2 -0)
frontend/appflowy_flutter/integration_test/mobile/document/plus_menu_test.dart (+89 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+54 -0)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/type_option_menu_item.dart (+16 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/add_block_toolbar_item.dart (+61 -6)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart (+10 -0)
frontend/resources/flowy_icons/16x/toggle_heading1.svg (+4 -0)
frontend/resources/flowy_icons/16x/toggle_heading2.svg (+4 -0)
frontend/resources/flowy_icons/16x/toggle_heading3.svg (+4 -0)

📄 Description

Feature Preview

  • add toogle headings in plus menu
  • click the expand icon should not cancel the selection
  • tests

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6784 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/14/2024 **Status:** ✅ Merged **Merged:** 11/14/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `add_toggle_heading_in_plus_menu` --- ### 📝 Commits (7) - [`6170a09`](https://github.com/AppFlowy-IO/AppFlowy/commit/6170a091480b62b67112fe53951a14191f84bcca) chore: add logs in space bloc - [`b372da6`](https://github.com/AppFlowy-IO/AppFlowy/commit/b372da61627c9a69e514741bfbbc2a864180abf0) feat: add toggle headings in plus menu - [`96fe1ed`](https://github.com/AppFlowy-IO/AppFlowy/commit/96fe1ed3399bf3e907a3e53757cc73b6b6e28c2a) test: add toggle heading block test - [`b51e962`](https://github.com/AppFlowy-IO/AppFlowy/commit/b51e96215e25a3e026aee45c8f4186b93ad2c5f8) test: toogle heading 1 block test - [`8e4a9bf`](https://github.com/AppFlowy-IO/AppFlowy/commit/8e4a9bf6d5dd0c691a01697fd573ddebbae2ebfb) test: add toggle heading selection test - [`2eb9eca`](https://github.com/AppFlowy-IO/AppFlowy/commit/2eb9eca5e1a205f0f9cc1ed577afda9e5fb02bcb) fix: toggle headings test - [`adcdb70`](https://github.com/AppFlowy-IO/AppFlowy/commit/adcdb70c62662c7bbbc7a89484498a62747bf064) chore: update new toggle heading icons ### 📊 Changes **12 files changed** (+251 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/mobile/document/document_test_runner.dart` (+2 -0) ➕ `frontend/appflowy_flutter/integration_test/mobile/document/plus_menu_test.dart` (+89 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+54 -0) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/type_option_menu_item.dart` (+16 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/option/turn_into_option_action.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/add_block_toolbar_item.dart` (+61 -6) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/workspace/application/sidebar/space/space_bloc.dart` (+10 -0) ➕ `frontend/resources/flowy_icons/16x/toggle_heading1.svg` (+4 -0) ➕ `frontend/resources/flowy_icons/16x/toggle_heading2.svg` (+4 -0) ➕ `frontend/resources/flowy_icons/16x/toggle_heading3.svg` (+4 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] add toogle headings in plus menu - [x] click the expand icon should not cancel the selection - [x] tests <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:15 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7574
No description provided.