[PR #6789] [MERGED] fix: rename untitled view #7578

New issue

Closed

opened 2026-03-23 23:20:16 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6789
Author: @Xazin
Created: 11/14/2024
Status: ✅ Merged
Merged: 12/12/2024
Merged by: @Xazin

Base: main ← Head: fix/rename-untitled-view

📝 Commits (8)

f482d37 fix: rename untitled view
fa7b9ec chore: merge branch 'upstream/main' into fix/rename-untitled-view
c84b8d0 test: add cloud test
b827fa0 chore: clean up code
9f2847a test: use nameOrDefault
aac62ea chore: merge branch 'upstream/main' into fix/rename-untitled-view
cb8d367 test: fix failing test
6fd25cc test: fix wrong assumption

📊 Changes

7 files changed (+66 additions, -16 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart (+3 -0)
➕ frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_rename_untitled_test.dart (+55 -0)
📝 frontend/appflowy_flutter/integration_test/shared/common_operations.dart (+2 -5)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart (+2 -4)
📝 frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart (+1 -5)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart (+1 -1)

📄 Description

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

~~Will add a regression test later.~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6789 **Author:** [@Xazin](https://github.com/Xazin) **Created:** 11/14/2024 **Status:** ✅ Merged **Merged:** 12/12/2024 **Merged by:** [@Xazin](https://github.com/Xazin) **Base:** `main` ← **Head:** `fix/rename-untitled-view` --- ### 📝 Commits (8) - [`f482d37`](https://github.com/AppFlowy-IO/AppFlowy/commit/f482d3796a366c8cc690981d39ac43522365aeee) fix: rename untitled view - [`fa7b9ec`](https://github.com/AppFlowy-IO/AppFlowy/commit/fa7b9eceb540c33cadef008e4eaf313a6fb5f8e5) chore: merge branch 'upstream/main' into fix/rename-untitled-view - [`c84b8d0`](https://github.com/AppFlowy-IO/AppFlowy/commit/c84b8d03834de2b178e158d5df72f610ce2b9918) test: add cloud test - [`b827fa0`](https://github.com/AppFlowy-IO/AppFlowy/commit/b827fa0bd5667980ab5bc1d9c9474fc76a447936) chore: clean up code - [`9f2847a`](https://github.com/AppFlowy-IO/AppFlowy/commit/9f2847a188cafe00cba8d2934a39472354220c29) test: use nameOrDefault - [`aac62ea`](https://github.com/AppFlowy-IO/AppFlowy/commit/aac62eabb4c9ae094adb41d776e44ba5ec713029) chore: merge branch 'upstream/main' into fix/rename-untitled-view - [`cb8d367`](https://github.com/AppFlowy-IO/AppFlowy/commit/cb8d367fed839a84ccebfe2e40505b9bdafa949d) test: fix failing test - [`6fd25cc`](https://github.com/AppFlowy-IO/AppFlowy/commit/6fd25cccf0f7e2147c79054cc9d0569fb088a59d) test: fix wrong assumption ### 📊 Changes **7 files changed** (+66 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/cloud/cloud_runner.dart` (+3 -0) ➕ `frontend/appflowy_flutter/integration_test/desktop/cloud/sidebar/sidebar_rename_untitled_test.dart` (+55 -0) 📝 `frontend/appflowy_flutter/integration_test/shared/common_operations.dart` (+2 -5) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart` (+2 -4) 📝 `frontend/appflowy_flutter/lib/plugins/database/tab_bar/mobile/mobile_tab_bar_header.dart` (+1 -5) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart` (+1 -1) </details> ### 📄 Description #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [ ] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. ~~Will add a regression test later.~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>