[PR #6795] [MERGED] fix: 0.7.4 launch review issues on mobile #7583

Closed
opened 2026-03-23 23:20:18 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6795
Author: @LucasXu0
Created: 11/15/2024
Status: Merged
Merged: 11/15/2024
Merged by: @LucasXu0

Base: mainHead: fix_lr_074_mobile


📝 Commits (10+)

  • 0bad27b feat: expand the hit test area for more button in space menu
  • a6fb6ee fix: contrast issue for the delte dialog text
  • bc07111 fix: stay in space menu after deleting a space
  • 05e3a33 fix: hide padding when space icon list is scrolled down
  • 18d76e6 feat: expand the hit test area for toggle button
  • 8e3ce9f feat: remove open workspace success toast
  • ff80f33 chore: update translations
  • 7ed296b test: stay in space menu after deleting a space
  • 12b131d chore: enable android test
  • 4565f0b fix: integration tests

📊 Changes

12 files changed (+254 additions, -174 deletions)

View changed files

📝 .github/workflows/android_ci.yaml.bak (+197 -126)
📝 .github/workflows/ios_ci.yaml (+1 -1)
📝 frontend/appflowy_flutter/integration_test/mobile/cloud/space/space_test.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart (+4 -10)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space_menu.dart (+8 -7)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/space/widgets.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart (+7 -5)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/add_block_toolbar_item.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart (+14 -11)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart (+4 -1)
📝 frontend/appflowy_flutter/packages/appflowy_result/lib/src/result.dart (+12 -8)
📝 frontend/resources/translations/en.json (+3 -0)

📄 Description

Feature Preview

  • epxand the hit test area for more button in space menu (no test)
  • contrast issue for the deletion dialog text (no test)
  • stay in space menu after deleting a space (test required)
  • hide padding when space icon list is scrolled down (no test)
  • remove the open workspace success toast (no test)
  • expand the hit test area for toggle button (no test)
  • update translations (no test)

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6795 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/15/2024 **Status:** ✅ Merged **Merged:** 11/15/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_lr_074_mobile` --- ### 📝 Commits (10+) - [`0bad27b`](https://github.com/AppFlowy-IO/AppFlowy/commit/0bad27bc86f177e7037bc2da92e87a4b44654e49) feat: expand the hit test area for more button in space menu - [`a6fb6ee`](https://github.com/AppFlowy-IO/AppFlowy/commit/a6fb6eeeec2c1f751f8a9676945acdb4b34da9a3) fix: contrast issue for the delte dialog text - [`bc07111`](https://github.com/AppFlowy-IO/AppFlowy/commit/bc07111aaa8852fddbae45a1764c39fc97842754) fix: stay in space menu after deleting a space - [`05e3a33`](https://github.com/AppFlowy-IO/AppFlowy/commit/05e3a333a36f0a1dc99ab81b8d88b842165688a0) fix: hide padding when space icon list is scrolled down - [`18d76e6`](https://github.com/AppFlowy-IO/AppFlowy/commit/18d76e6c35642b2885f4f14ca0d7df9520a7865a) feat: expand the hit test area for toggle button - [`8e3ce9f`](https://github.com/AppFlowy-IO/AppFlowy/commit/8e3ce9f38a6346e507cce91bd25a4a408eee5a1f) feat: remove open workspace success toast - [`ff80f33`](https://github.com/AppFlowy-IO/AppFlowy/commit/ff80f33e78a9526073ab59a2efb223ddd8fbec38) chore: update translations - [`7ed296b`](https://github.com/AppFlowy-IO/AppFlowy/commit/7ed296bad48562d4c1e4eed97f9bbd25966c529d) test: stay in space menu after deleting a space - [`12b131d`](https://github.com/AppFlowy-IO/AppFlowy/commit/12b131df9cb0b7e9272aa7bcd3400927cc340bc5) chore: enable android test - [`4565f0b`](https://github.com/AppFlowy-IO/AppFlowy/commit/4565f0b3dfe797414701bf24a28bbfec30e6f145) fix: integration tests ### 📊 Changes **12 files changed** (+254 additions, -174 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/android_ci.yaml.bak` (+197 -126) 📝 `.github/workflows/ios_ci.yaml` (+1 -1) 📝 `frontend/appflowy_flutter/integration_test/mobile/cloud/space/space_test.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_page.dart` (+4 -10) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/space/mobile_space_menu.dart` (+8 -7) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/space/widgets.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/home/workspaces/workspace_menu_bottom_sheet.dart` (+7 -5) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/add_block_toolbar_item.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_component.dart` (+14 -11) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart` (+4 -1) 📝 `frontend/appflowy_flutter/packages/appflowy_result/lib/src/result.dart` (+12 -8) 📝 `frontend/resources/translations/en.json` (+3 -0) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] epxand the hit test area for more button in space menu (no test) - [x] contrast issue for the deletion dialog text (no test) - [x] stay in space menu after deleting a space (test required) - [x] hide padding when space icon list is scrolled down (no test) - [x] remove the open workspace success toast (no test) - [x] expand the hit test area for toggle button (no test) - [x] update translations (no test) <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [ ] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:18 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7583
No description provided.