[PR #6824] [MERGED] feat: support creating subpage block in row detail page #7592

Closed
opened 2026-03-23 23:20:20 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6824
Author: @LucasXu0
Created: 11/18/2024
Status: Merged
Merged: 11/19/2024
Merged by: @LucasXu0

Base: mainHead: support_subpage_block_in_row_page


📝 Commits (8)

  • 0e45e29 feat: support creating subpage block in row detail page
  • 956e5e9 feat: hide the row page from sidebar
  • 7acec5f test: support creating a sub-page block in row detail page
  • 01c494a fix: update drag block logic
  • 9288b26 Merge branch 'main' into support_subpage_block_in_row_page
  • 29c8f8c feat: support toggle heading in outline
  • 8153443 test: add toggle headings show in outline block test
  • 1a13b7c fix: unable to get focus when opening subpage from card

📊 Changes

15 files changed (+298 additions, -143 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/database/database_row_page_test.dart (+23 -5)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart (+3 -4)
📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_outline_block_test.dart (+27 -10)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_document.dart (+32 -18)
📝 frontend/appflowy_flutter/lib/plugins/database_document/database_document_page.dart (+12 -8)
📝 frontend/appflowy_flutter/lib/plugins/database_document/presentation/database_document_title.dart (+3 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/document_page.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart (+4 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/util.dart (+4 -15)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart (+33 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/appflowy_mobile_toolbar.dart (+3 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/outline/outline_block_component.dart (+58 -46)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shared_context/shared_context.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items.dart (+65 -13)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_block_component.dart (+26 -8)

📄 Description

Feature Preview

  • support creating a sub-page block in row detail page
  • test
  • navigate to the newly created sub-page
  • test
  • view title (not support)
  • the sub-page will lose focus after opening from card

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6824 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `support_subpage_block_in_row_page` --- ### 📝 Commits (8) - [`0e45e29`](https://github.com/AppFlowy-IO/AppFlowy/commit/0e45e2993bb654f99c3c928bf193b2c854b858e9) feat: support creating subpage block in row detail page - [`956e5e9`](https://github.com/AppFlowy-IO/AppFlowy/commit/956e5e9e18e157593391daa3be4f26f1c10cd0b9) feat: hide the row page from sidebar - [`7acec5f`](https://github.com/AppFlowy-IO/AppFlowy/commit/7acec5fbf8c1fd1e878be6da51f2711c01fad84b) test: support creating a sub-page block in row detail page - [`01c494a`](https://github.com/AppFlowy-IO/AppFlowy/commit/01c494a5cefda3032ae3d07014b4abe07c0a22ac) fix: update drag block logic - [`9288b26`](https://github.com/AppFlowy-IO/AppFlowy/commit/9288b2626354ae0ae6ac92f077e83ea970effa45) Merge branch 'main' into support_subpage_block_in_row_page - [`29c8f8c`](https://github.com/AppFlowy-IO/AppFlowy/commit/29c8f8cd8401e40dc563b60233580561c0e76bcd) feat: support toggle heading in outline - [`8153443`](https://github.com/AppFlowy-IO/AppFlowy/commit/81534431acd6eb30b6e18c909d6ed65d40ebc7d1) test: add toggle headings show in outline block test - [`1a13b7c`](https://github.com/AppFlowy-IO/AppFlowy/commit/1a13b7cc49952e9f0b0f60b7fd16772773ef844f) fix: unable to get focus when opening subpage from card ### 📊 Changes **15 files changed** (+298 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/database/database_row_page_test.dart` (+23 -5) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_sub_page_test.dart` (+3 -4) 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_outline_block_test.dart` (+27 -10) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/row/row_document.dart` (+32 -18) 📝 `frontend/appflowy_flutter/lib/plugins/database_document/database_document_page.dart` (+12 -8) 📝 `frontend/appflowy_flutter/lib/plugins/database_document/presentation/database_document_title.dart` (+3 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/document_page.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart` (+4 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/util.dart` (+4 -15) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/header/cover_title.dart` (+33 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/appflowy_mobile_toolbar.dart` (+3 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/outline/outline_block_component.dart` (+58 -46) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/shared_context/shared_context.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items.dart` (+65 -13) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_block_component.dart` (+26 -8) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] support creating a sub-page block in row detail page - [x] test - [x] navigate to the newly created sub-page - [x] test - [ ] ~~view title (not support)~~ - [x] the sub-page will lose focus after opening from card <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:20 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7592
No description provided.