[PR #6897] [MERGED] fix(desktop): resize sidebar menu regression #7628

Closed
opened 2026-03-23 23:20:30 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6897
Author: @richardshiue
Created: 12/1/2024
Status: Merged
Merged: 12/3/2024
Merged by: @richardshiue

Base: mainHead: fix/resize-sidebar-regression


📝 Commits (1)

  • 6e3c456 fix(desktop): resize sidebar menu regression

📊 Changes

3 files changed (+5 additions, -6 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/workspace/application/home/home_setting_bloc.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/home/home_layout.dart (+4 -3)
📝 frontend/appflowy_flutter/packages/flowy_infra/lib/size.dart (+0 -2)

📄 Description

illustration of bug:

https://github.com/user-attachments/assets/afe00f43-cbb2-4ed4-9732-497f3000810d

cause: negative resize offsets are no longer allowed

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6897 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/1/2024 **Status:** ✅ Merged **Merged:** 12/3/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/resize-sidebar-regression` --- ### 📝 Commits (1) - [`6e3c456`](https://github.com/AppFlowy-IO/AppFlowy/commit/6e3c456537481688f81040e2113a9d66de0b9df7) fix(desktop): resize sidebar menu regression ### 📊 Changes **3 files changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/workspace/application/home/home_setting_bloc.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/home/home_layout.dart` (+4 -3) 📝 `frontend/appflowy_flutter/packages/flowy_infra/lib/size.dart` (+0 -2) </details> ### 📄 Description illustration of bug: https://github.com/user-attachments/assets/afe00f43-cbb2-4ed4-9732-497f3000810d cause: negative resize offsets are no longer allowed ### Feature Preview <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:30 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7628
No description provided.