[PR #6909] [MERGED] fix: pressing enter on a collapsible list toggle adds an additional new line #7632

New issue

Closed

opened 2026-03-23 23:20:31 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6909
Author: @LucasXu0
Created: 12/3/2024
Status: ✅ Merged
Merged: 12/3/2024
Merged by: @LucasXu0

Base: main ← Head: fix_6881

📝 Commits (4)

b2c72b9 fix: pressing Enter on a closed toggle list adds an additional new line
74d5ab3 test: pressing Enter on a closed toggle list adds an additional new line
0f09971 chore: upgrade appflowy_editor
fcb0871 chore: rename table align

📊 Changes

11 files changed (+156 additions, -91 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_list.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/_shared_widget.dart (+23 -24)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_block_component.dart (+55 -52)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_constants.dart (+42 -8)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_operations/simple_table_node_extension.dart (+3 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcuts.dart (+0 -1)
📝 frontend/appflowy_flutter/pubspec.lock (+2 -2)
📝 frontend/appflowy_flutter/pubspec.yaml (+1 -1)
📝 frontend/appflowy_flutter/test/unit_test/document/shortcuts/toggle_list_shortcut_test.dart (+26 -0)
📝 frontend/scripts/code_generation/language_files/generate_language_files.cmd (+2 -0)

📄 Description

Feature Preview

closes https://github.com/AppFlowy-IO/AppFlowy/issues/6881

pressing enter on a collapsible list toggle adds an additional new line
test
upgrade appflowy_editor

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6909 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 12/3/2024 **Status:** ✅ Merged **Merged:** 12/3/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_6881` --- ### 📝 Commits (4) - [`b2c72b9`](https://github.com/AppFlowy-IO/AppFlowy/commit/b2c72b9449b07af25feb6e6175d25c1d43421bbe) fix: pressing Enter on a closed toggle list adds an additional new line - [`74d5ab3`](https://github.com/AppFlowy-IO/AppFlowy/commit/74d5ab3d43a25d498c4a80fb68f763135d004633) test: pressing Enter on a closed toggle list adds an additional new line - [`0f09971`](https://github.com/AppFlowy-IO/AppFlowy/commit/0f099719918091dec2ce7b5c404e285ecc6944ad) chore: upgrade appflowy_editor - [`fcb0871`](https://github.com/AppFlowy-IO/AppFlowy/commit/fcb08719a975216fd91897ca483c9354e2290a6a) chore: rename table align ### 📊 Changes **11 files changed** (+156 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_configuration.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_list.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/_shared_widget.dart` (+23 -24) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_block_component.dart` (+55 -52) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_constants.dart` (+42 -8) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_operations/simple_table_node_extension.dart` (+3 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcuts.dart` (+0 -1) 📝 `frontend/appflowy_flutter/pubspec.lock` (+2 -2) 📝 `frontend/appflowy_flutter/pubspec.yaml` (+1 -1) 📝 `frontend/appflowy_flutter/test/unit_test/document/shortcuts/toggle_list_shortcut_test.dart` (+26 -0) 📝 `frontend/scripts/code_generation/language_files/generate_language_files.cmd` (+2 -0) </details> ### 📄 Description   ### Feature Preview closes https://github.com/AppFlowy-IO/AppFlowy/issues/6881 - [x] pressing enter on a collapsible list toggle adds an additional new line - [x] test - [x] upgrade appflowy_editor  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>