[PR #6927] [MERGED] fix: unable to open local file using afLaunchUrl function #7643

Closed
opened 2026-03-23 23:20:34 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6927
Author: @LucasXu0
Created: 12/6/2024
Status: Merged
Merged: 12/6/2024
Merged by: @LucasXu0

Base: mainHead: fix_open_local_file_error


📝 Commits (5)

  • 5e3730b fix: unable to open local file using afLaunchUrl function
  • eea1cd3 chore: use the latest api to open the local file
  • 00f5353 chore: use the latest api to open the local file
  • a4e1726 chore: use the latest api to open the local file
  • 731c294 test: add local paht regex test

📊 Changes

15 files changed (+128 additions, -51 deletions)

View changed files

📝 frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart (+74 -5)
📝 frontend/appflowy_flutter/lib/mobile/presentation/base/view_page/more_bottom_sheet.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_media_cell.dart (+6 -7)
📝 frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_media_cell.dart (+1 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_block_component.dart (+1 -18)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_util.dart (+2 -3)
📝 frontend/appflowy_flutter/lib/shared/patterns/common_patterns.dart (+3 -0)
📝 frontend/appflowy_flutter/lib/user/application/auth/af_cloud_auth_service.dart (+1 -1)
📝 frontend/appflowy_flutter/lib/util/share_log_files.dart (+2 -2)
📝 frontend/appflowy_flutter/lib/workspace/application/settings/ai/plugin_state_bloc.dart (+2 -1)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_manage_data_view.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_learn_more_button.dart (+3 -4)
📝 frontend/appflowy_flutter/lib/workspace/presentation/widgets/image_viewer/interactive_image_toolbar.dart (+2 -2)
frontend/appflowy_flutter/test/unit_test/url_launcher/url_launcher_test.dart (+19 -0)
📝 frontend/resources/translations/en.json (+8 -1)

📄 Description

Feature Preview

  • unable to open local file using afLaunchUrl function
  • combine the launchers for local and network files into the same function
  • test

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6927 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/6/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `fix_open_local_file_error` --- ### 📝 Commits (5) - [`5e3730b`](https://github.com/AppFlowy-IO/AppFlowy/commit/5e3730b6cfa47046b31e5fcd29cbdf938243121e) fix: unable to open local file using afLaunchUrl function - [`eea1cd3`](https://github.com/AppFlowy-IO/AppFlowy/commit/eea1cd3480d7fe7615232ed49d6494ce75086f0b) chore: use the latest api to open the local file - [`00f5353`](https://github.com/AppFlowy-IO/AppFlowy/commit/00f535337cd1ceaeeba44ed093110af66228040a) chore: use the latest api to open the local file - [`a4e1726`](https://github.com/AppFlowy-IO/AppFlowy/commit/a4e172632399533a8c8adcea4108c23d35ebbc1b) chore: use the latest api to open the local file - [`731c294`](https://github.com/AppFlowy-IO/AppFlowy/commit/731c29412f9a95bf0f37492e3f0dc2f62587f82b) test: add local paht regex test ### 📊 Changes **15 files changed** (+128 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart` (+74 -5) 📝 `frontend/appflowy_flutter/lib/mobile/presentation/base/view_page/more_bottom_sheet.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_grid/desktop_grid_media_cell.dart` (+6 -7) 📝 `frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_media_cell.dart` (+1 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_block_component.dart` (+1 -18) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/file/file_util.dart` (+2 -3) 📝 `frontend/appflowy_flutter/lib/shared/patterns/common_patterns.dart` (+3 -0) 📝 `frontend/appflowy_flutter/lib/user/application/auth/af_cloud_auth_service.dart` (+1 -1) 📝 `frontend/appflowy_flutter/lib/util/share_log_files.dart` (+2 -2) 📝 `frontend/appflowy_flutter/lib/workspace/application/settings/ai/plugin_state_bloc.dart` (+2 -1) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_manage_data_view.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/theme_upload/theme_upload_learn_more_button.dart` (+3 -4) 📝 `frontend/appflowy_flutter/lib/workspace/presentation/widgets/image_viewer/interactive_image_toolbar.dart` (+2 -2) ➕ `frontend/appflowy_flutter/test/unit_test/url_launcher/url_launcher_test.dart` (+19 -0) 📝 `frontend/resources/translations/en.json` (+8 -1) </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] unable to open local file using `afLaunchUrl` function - [x] combine the launchers for local and network files into the same function - [x] test <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:34 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7643
No description provided.