[PR #6933] [MERGED] fix(flutter): implement mention date transaction handler #7648

New issue

Closed

opened 2026-03-23 23:20:35 +00:00 by mirror · 0 comments

mirror commented

2026-03-23 23:20:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6933
Author: @richardshiue
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @richardshiue

Base: main ← Head: fix/delete-reminder

📝 Commits (4)

76deb6c fix: implement mention date transaction handler
a398361 test: add integration tests
d7dc016 chore: code cleanup
01b368b chore: early return if null delta

📊 Changes

8 files changed (+627 additions, -14 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_date_reminder_test.dart (+342 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart (+2 -1)
➕ frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/date_transaction_handler.dart (+263 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_transaction_handler.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_handler.dart (+1 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart (+17 -4)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/mention_transaction_handler.dart (+1 -7)

📄 Description

resolve #6913

~~TODO: fix, test~~ (done)

Feature Preview

PR Checklist

My code adheres to AppFlowy's Conventions
I've listed at least one issue that this PR fixes in the description above.
I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
All existing tests are passing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6933 **Author:** [@richardshiue](https://github.com/richardshiue) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@richardshiue](https://github.com/richardshiue) **Base:** `main` ← **Head:** `fix/delete-reminder` --- ### 📝 Commits (4) - [`76deb6c`](https://github.com/AppFlowy-IO/AppFlowy/commit/76deb6cf1b4cd7e51acea1a698b225da27cbdc2e) fix: implement mention date transaction handler - [`a398361`](https://github.com/AppFlowy-IO/AppFlowy/commit/a398361c1c7192e494abc8e7804408b8489f7a88) test: add integration tests - [`d7dc016`](https://github.com/AppFlowy-IO/AppFlowy/commit/d7dc01621cc2b428076d49d8ecae5f74507dfeea) chore: code cleanup - [`01b368b`](https://github.com/AppFlowy-IO/AppFlowy/commit/01b368be6a7ea1f6bcf98e174d2d3c7d6b7121ec) chore: early return if null delta ### 📊 Changes **8 files changed** (+627 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_date_reminder_test.dart` (+342 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/child_page_transaction_handler.dart` (+2 -1) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/date_transaction_handler.dart` (+263 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mention/mention_block.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/sub_page/sub_page_transaction_handler.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_handler.dart` (+1 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/editor_transaction_service.dart` (+17 -4) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/transaction_handler/mention_transaction_handler.dart` (+1 -7) </details> ### 📄 Description resolve #6913 ~~TODO: fix, test~~ (done) ### Feature Preview  ---  #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>