[PR #6956] [MERGED] feat: set table to page width #7658

Closed
opened 2026-03-23 23:20:38 +00:00 by mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/AppFlowy-IO/AppFlowy/pull/6956
Author: @LucasXu0
Created: 12/10/2024
Status: Merged
Merged: 12/11/2024
Merged by: @LucasXu0

Base: mainHead: set_page_width


📝 Commits (6)

  • 39f6a3a feat: set table to page width
  • 0425f12 feat: expand the table based on the widht percentage
  • e31745c test: set to page width
  • f80b5a1 feat: distribute columns evenly
  • c73f2d0 test: distribute columns evenly
  • 481fd6c fix: border width

📊 Changes

25 files changed (+577 additions, -324 deletions)

View changed files

📝 frontend/appflowy_flutter/integration_test/desktop/document/document_with_simple_table_test.dart (+75 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/_shared_widget.dart (+0 -251)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table.dart (+1 -3)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_cell_block_component.dart (+0 -2)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_constants.dart (+4 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_more_action.dart (+67 -43)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_operations/simple_table_node_extension.dart (+10 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_operations/simple_table_style_operation.dart (+85 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_row_block_component.dart (+1 -2)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_align_button.dart (+81 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_background_menu.dart (+104 -0)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_basic_button.dart (+50 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_border_builder.dart (+17 -11)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_divider.dart (+28 -0)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_reorder_button.dart (+0 -1)
📝 frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_widget.dart (+0 -1)
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/widgets.dart (+11 -0)
📝 frontend/resources/flowy_icons/16x/table_clear_content.svg (+9 -2)
frontend/resources/flowy_icons/16x/table_distribute_columns_evenly.svg (+9 -0)
📝 frontend/resources/flowy_icons/16x/table_insert_above.svg (+4 -1)

...and 5 more files

📄 Description

Feature Preview

  • set to page width
  • distribute columns evenly
  • replace the order of the items in table menu
  • test

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/AppFlowy-IO/AppFlowy/pull/6956 **Author:** [@LucasXu0](https://github.com/LucasXu0) **Created:** 12/10/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@LucasXu0](https://github.com/LucasXu0) **Base:** `main` ← **Head:** `set_page_width` --- ### 📝 Commits (6) - [`39f6a3a`](https://github.com/AppFlowy-IO/AppFlowy/commit/39f6a3aeda835018c6b632416b7953ad668a2ea7) feat: set table to page width - [`0425f12`](https://github.com/AppFlowy-IO/AppFlowy/commit/0425f12b2a388391aeb24fa2ee4ed36e86e476fd) feat: expand the table based on the widht percentage - [`e31745c`](https://github.com/AppFlowy-IO/AppFlowy/commit/e31745c1ad321a34fcdc9e7237ea87a182630aff) test: set to page width - [`f80b5a1`](https://github.com/AppFlowy-IO/AppFlowy/commit/f80b5a156ec7be50e15dbdf6d982e2ee984f93b8) feat: distribute columns evenly - [`c73f2d0`](https://github.com/AppFlowy-IO/AppFlowy/commit/c73f2d03232662f46c7f68c436a39c4b7d946245) test: distribute columns evenly - [`481fd6c`](https://github.com/AppFlowy-IO/AppFlowy/commit/481fd6c7aa35e83192d8c35f5a638aea9784ed37) fix: border width ### 📊 Changes **25 files changed** (+577 additions, -324 deletions) <details> <summary>View changed files</summary> 📝 `frontend/appflowy_flutter/integration_test/desktop/document/document_with_simple_table_test.dart` (+75 -0) ➖ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/_shared_widget.dart` (+0 -251) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table.dart` (+1 -3) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_cell_block_component.dart` (+0 -2) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_constants.dart` (+4 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_more_action.dart` (+67 -43) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_operations/simple_table_node_extension.dart` (+10 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_operations/simple_table_style_operation.dart` (+85 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_row_block_component.dart` (+1 -2) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_align_button.dart` (+81 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_background_menu.dart` (+104 -0) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_basic_button.dart` (+50 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_border_builder.dart` (+17 -11) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_divider.dart` (+28 -0) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_reorder_button.dart` (+0 -1) 📝 `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/simple_table_widget.dart` (+0 -1) ➕ `frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/simple_table/simple_table_widgets/widgets.dart` (+11 -0) 📝 `frontend/resources/flowy_icons/16x/table_clear_content.svg` (+9 -2) ➕ `frontend/resources/flowy_icons/16x/table_distribute_columns_evenly.svg` (+9 -0) 📝 `frontend/resources/flowy_icons/16x/table_insert_above.svg` (+4 -1) _...and 5 more files_ </details> ### 📄 Description <!--- Thank you for submitting a pull request to AppFlowy. The team will dedicate their best efforts to reviewing and approving your pull request. If you have any questions about the project or feedback for us, please join our [Discord](https://discord.gg/wdjWUXXhtw). --> <!--- If your pull request adds a new feature, please drag and drop a video into this section to showcase what you've done! If not, you may delete this section. --> ### Feature Preview - [x] set to page width - [x] distribute columns evenly - [x] replace the order of the items in table menu - [x] test <!--- List at least one issue here that this PR addresses. If it fixes the issue, please use the [fixes](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) keyword to close the issue. For example: fixes https://github.com/AppFlowy-IO/AppFlowy/pull/2106 --> --- <!--- Before you mark this PR ready for review, run through this checklist! --> #### PR Checklist - [x] My code adheres to [AppFlowy's Conventions](https://docs.appflowy.io/docs/documentation/software-contributions/conventions) - [x] I've listed at least one issue that this PR fixes in the description above. - [x] I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes. - [x] All existing tests are passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
mirror 2026-03-23 23:20:38 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AppFlowy-IO/AppFlowy#7658
No description provided.